1337560 - Switch Yahoo, Amazon and Yandex to use chrome icon

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mike Kaply [:mkaply]]

Now that i've verified the concept for wikipedia in bug 1332741, I'm going to finish off our other search engines.

For Yahoo, Yandex and Amazon, where the icons are exactly the same, we should switch to using an icon in chrome instead of storing the data URL.

Comment 1

[Mike Kaply [:mkaply]]

Attachment: Bug 1337560. Switch Yahoo and Amazon to use chrome icon.

Review commit: https://reviewboard.mozilla.org/r/110792/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110792/

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8835073 [details]
Bug 1337560. Switch Yahoo and Amazon to use chrome icon.

https://reviewboard.mozilla.org/r/110792/#review112268

Technically this looks good, but I don't think we should ship a 18 kB image. If that's OK, I'm happy to turn this in a r+.

It's the same icon amazon.com uses, but it contains 48,32,24,16 pixel images, and we only need two of those.

Comment 3

[Francesco Lodolo [:flod]]

Attachment: amazon.ico

I've tried to play a bit with the image. The weirdness is that the original .ico has a darker gray shade on the rounded corners that disappears when you extract PNG from it (tried with both software and online tools).

This file is 1 kB, contains only 16+32 optimized icons. Enlarged it doesn't show any difference compared to the original image, minus the corners.

Comment 4

[Mike Kaply [:mkaply]]

I'd forgotten to check amazon icon sizes. tx

Comment 5

[Mike Kaply [:mkaply]]

Attachment: Bad amazon.ico

This is the data: url converted to an icon which is only 1219 but for some reason only works in the browser (same problem we had with wikipedia). 

On Mac, you can't view it in Preview and the OS doesn't know what to do with it either.

I don't understand how we have these broken data: URL icons...

Comment 6

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #5)
> I don't understand how we have these broken data: URL icons...
I have no clue either. This URL doesn't show the darker corners, so it should be safe to use the one I've attached before.

Comment 7

[Francesco Lodolo [:flod]]

Looks like this one fell off the radar? It should be in pretty good shape to land, just needs the fix for the icon.

Comment 8

[Mike Kaply [:mkaply]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6bd0eb2c8bab71df7e23af5a33d1e30ceac37bd
Bug 1337560 - Use chrome icons for Yahoo and Amazon. r=flod

Comment 9

[Mike Kaply [:mkaply]]

Sorry about that. Done now.

I'm going to do Yandex separately because besides there being two different Yandex icons (english, russian), yandex is using two different favicons on their site.

Note, however, that there is already a yandex-en image in the build (for other purposes)

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/f6bd0eb2c8ba

Comment 11

[krithivelan25]

[Bugday-20170315]
The bug is verified.
OS: Windows 7
Browser:Nightly 55