1337565 - After changing language, interface show that I have selected English (US)

Status: VERIFIED FIXED

(support.mozilla.org :: Localization, task)

Description

[Tomáš Zelina (Mozilla.cz) [:zelitomas]]

Attachment: Bug - red underline

Hello, I am glad that migration to Lithium is finally finished, but unfortunately it brought some localization issues. 

After switching languages, the interface still says that you have selected English (US) locale (in footer and top corner)

Comment 1

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Actually it shows the language name according to the user preferences (https://support.mozilla.org/t5/user/myprofilepage/tab/user-preferences), which default to English when you are not logged in.

Comment 2

[vesper]

I confirm, this is showing your account's language preference (which influences the UI of the site).

We are considering removing the text with the language name from the icon, as it may be a bit confusing to users to keep seeing it there, when they change to a different language node.

Comment 3

[vesper]

Scott, is this a change we can do on our own (e.g. via Studio) or is this a built-in feature we'd need Lithium's help with? Thanks!

Comment 4

[scott.riley]

Hi Michal,  Think it just comes down to which experience you prefer to happen.  As you identified, the component is relying on <#assign userLanguage = user.get("profile.language")!"en" />.  If it should be displaying the language of that node selected rather that what's there now, you'll want to swap that w/
<#assign userLanguage = coreNode.settings.name.get("profile.language", "en") />

on this component https://support-stage.allizom.org/t5/bizapps/bizappspage/tab/community%3Astudio%3Acustom-content?component=custom.language-button

Comment 5

[vesper]

Thank you for your help with this, Scott!

I have changed the code and it works as you described on stage. We'll have that live later this week with a push to prod.

Cheers,
Michał

Comment 6

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

I can verify it works, both when I am logged in or not.