1337578 - Intermittent application crashed [@ js::GCMarker::eagerlyMarkChildren][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)][@ js::GCMarker::eagerlyMarkChildren(JSRope*)]

Reporter

Description

•

7 years ago

treeherder

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=75257850&repo=autoland

https://queue.taskcluster.net/v1/task/eWqWgzDTRVm7hwDcAVEKBw/runs/0/artifacts/public/logs/live_backing.log

Marco Bonardo [:mak] (Away Apr 25 - May 5)

Comment 1

•

7 years ago

Looks like a crash in GC. I'm not sure who could evaluate this stack, Olly, could you please help finding the appropriate person? I've no idea if this is actionable.

Flags: needinfo?(bugs)

Olli Pettay [:smaug][bugs@pettay.fi]

Updated

•

7 years ago

Flags: needinfo?(bugs) → needinfo?(jcoppeard)

Comment hidden (Intermittent Failures Robot)

17 failures in 836 pushes (0.02 failures/push) were associated with this bug in the last 7 days.  
Repository breakdown:
* autoland: 10
* mozilla-inbound: 5
* try: 1
* mozilla-central: 1

Platform breakdown:
* linux32: 13
* linux64: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1337578&startday=2017-02-06&endday=2017-02-12&tree=all

Marco Bonardo [:mak] (Away Apr 25 - May 5)

Updated

•

7 years ago

Updated

•

7 years ago

Comment 4

•

7 years ago

Tests in which this is happening:

browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js
browser/base/content/test/general/browser_tab_dragdrop2.js
browser/components/search/test/browser_webapi.js
browser/components/extensions/test/browser/test-oop-extensions/browser_ext_tabs_detectLanguage.js
browser/components/customizableui/test/browser_885052_customize_mode_observers_disabed.js
browser/components/extensions/test/browser/browser_ext_tabs_cookieStoreId.js
browser/base/content/test/general/browser_tab_drag_drop_perwindow.js
browser_ext_tabs_duplicate.js
browser/base/content/test/general/browser_tabs_owner.js
browser/base/content/test/general/browser_temporary_permissions.js
browser/base/content/test/general/browser_trackingUI_4.js
browser/base/content/test/general/browser_tabs_isActive.js
browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js

I'm going to try to dedupe these bugs so we collect failures in one place and can accurately assess how bad this is.

Component: Location Bar → JavaScript: GC

Product: Firefox → Core

Summary: Intermittent browser/base/content/test/urlbar/browser_urlbarSearchSingleWordNotification.js | application crashed [@ js::GCMarker::eagerlyMarkChildren] → Intermittent <random-browser-test>.js | application crashed [@ js::GCMarker::eagerlyMarkChildren][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)]

:Gijs (he/him)

Comment 5

•

7 years ago

There's a possible regressor in bug 1335582, so I guess I'll add that as see also and leave open

URL: 1335582

Updated

•

7 years ago

Summary: Intermittent <random-browser-test>.js | application crashed [@ js::GCMarker::eagerlyMarkChildren][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)] → Intermittent <random-browser-test>.js | application crashed [@ js::GCMarker::eagerlyMarkChildren][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)][@ js::GCMarker::eagerlyMarkChildren(JSRope*)]

Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)

Updated

•

7 years ago

Crash Signature: [@ js::GCMarker::eagerlyMarkChildren] [@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)] [@ js::GCMarker::eagerlyMarkChildren(JSRope*)]

Summary: Intermittent <random-browser-test>.js | application crashed [@ js::GCMarker::eagerlyMarkChildren][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)][@ js::GCMarker::eagerlyMarkChildren(JSRope*)] → Intermittent application crashed [@ js::GCMarker::eagerlyMarkChildren][@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)][@ js::GCMarker::eagerlyMarkChildren(JSRope*)]

Comment hidden (Intermittent Failures Robot)

38 failures in 845 pushes (0.045 failures/push) were associated with this bug in the last 7 days. 

This is the #48 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 19
* mozilla-inbound: 15
* mozilla-central: 3
* try: 1

Platform breakdown:
* osx-10-10: 11
* windows7-32-vm: 9
* linux32: 8
* windows8-64: 7
* linux64: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1337578&startday=2017-03-27&endday=2017-04-02&tree=all

Joel Maher ( :jmaher ) (UTC -8)

Comment 20

•

7 years ago

this seems to have started up again on March 29th at a pretty high rate, doing some retriggers of win7-debug-bc-7 (although there are other patterns):
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=browser-chrome-7%20win%20debug&tochange=73779bff009253588da41b6e4a30b1d3b80b990d&fromchange=8b964027442044f5fe933e2fc92eb6704e706798&selectedJob=87278080

Whiteboard: [stockwell needswork]

Joel Maher ( :jmaher ) (UTC -8)

Comment 21

•

7 years ago

odd, disabling a couple reftests caused this?  I suspect it is a build specific issue, although this leads me to more confusion than usefulness.

I see :jonco has been needinfo'd for 2 months now, this is something someone on his team would need to help out with.

Robert Lindsay

Comment 22

•

7 years ago

Not sure if this is helpful, but just got six crashes here with this signature and the exact same crashing thread within 12 seconds of each other, which is one crash every two seconds.

https://crash-stats.mozilla.com/report/index/bp-4306d0a4-0361-409d-a62e-0171c2170323
https://crash-stats.mozilla.com/report/index/bp-f6798ba9-caa7-40da-8071-f16572170323
https://crash-stats.mozilla.com/report/index/bp-21eb016e-5123-4149-9913-809e02170323
https://crash-stats.mozilla.com/report/index/bp-9e0e0b04-0ca4-41bf-980f-3f51b2170323
https://crash-stats.mozilla.com/report/index/bp-9b10ecd0-1acd-4908-bfbd-b1b882170323
https://crash-stats.mozilla.com/report/index/bp-5df473a7-3854-4eff-90fc-d62f12170323

I am not sure what exactly I was doing at that time. Any way to figure out what I was doing at that day on that time?

This is not a new crash bug. Eagerly Mark Children has been crashing a lot in versions 49 for me, all iterations. It's one of the most common crashes. So this crash has been going on for at least since v. 49 and in the older bug reports, I believe they were saying that it started a lot earlier. They also thought it was unfixable because they could not figure out what was crashing it. Seems to be related to Rope crashes, GSRope and JSRope too.

Phil Ringnalda (:philor)

Updated

•

7 years ago

Crash Signature: [@ js::GCMarker::eagerlyMarkChildren] [@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)] [@ js::GCMarker::eagerlyMarkChildren(JSRope*)] → [@ js::GCMarker::eagerlyMarkChildren] [@ js::GCMarker::eagerlyMarkChildren(JSLinearString*)] [@ js::GCMarker::eagerlyMarkChildren(JSLinearString *)] [@ js::GCMarker::eagerlyMarkChildren(JSRope*)]

Comment hidden (Intermittent Failures Robot)

93 failures in 867 pushes (0.107 failures/push) were associated with this bug in the last 7 days. 

This is the #15 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 43
* autoland: 43
* mozilla-central: 5
* mozilla-aurora: 2

Platform breakdown:
* osx-10-10: 41
* windows8-64: 19
* windows7-32-vm: 15
* linux32: 10
* linux64: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1337578&startday=2017-04-03&endday=2017-04-09&tree=all

Joel Maher ( :jmaher ) (UTC -8)

Comment 24

•

7 years ago

:jonco, can you comment on this bug with what you believe is going on and when we can expect a fix?

Jon Coppeard (:jonco)

Assignee

Comment 25

•

7 years ago

The crash-stats data for js::GCMarker::eagerlyMarkChildren goes back a long time and encompasses many different stacks.

However the intermittent test failures all come through JSFunction::trace when marking the function's atom.   That and the time this was reported suggest bug 1324002 may be implicated.

Flags: needinfo?(jcoppeard)

Andrew McCreight [:mccr8]

Updated

•

7 years ago

Blocks: 1324002

Andrew McCreight [:mccr8]

Comment 26

•

7 years ago

Some tests that seem to show up more than others. There are 11 of these crashes in the last week in e10s browser/base/content/test/general/browser_testOpenNewRemoteTabsFromNonRemoteBrowsers.js, for instance.

Jon Coppeard (:jonco)

Assignee

Comment 27

•

7 years ago

Attached patch bug1337578-mark-fun-atom — Details — Splinter Review

Patch to mark atoms when cloning functions.

Assignee: nobody → jcoppeard

Attachment #8857000 - Flags: review?(bhackett1024)

Andrew McCreight [:mccr8]

Updated

•

7 years ago

status-firefox53: --- → unaffected

status-firefox54: --- → affected

status-firefox55: --- → affected

Keywords: regression

Andrew McCreight [:mccr8]

Updated

•

7 years ago

Blocks: 1353621

Brian Hackett [Laid off!]

Updated

•

7 years ago

Attachment #8857000 - Flags: review?(bhackett1024) → review+

Comment hidden (Intermittent Failures Robot)

16 failures in 153 pushes (0.105 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 7
* autoland: 7
* mozilla-central: 2

Platform breakdown:
* osx-10-10: 8
* linux32: 3
* windows7-32-vm: 2
* linux64: 2
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1337578&startday=2017-04-11&endday=2017-04-11&tree=all

Pulsebot

Comment 30

•

7 years ago

Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/38889a153f45
Mark atoms when cloning functions r=bhackett

Andrew McCreight [:mccr8]

Comment 31

•

7 years ago

[Tracking Requested - why for this release]: crash regression

tracking-firefox54: --- → ?

Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)

Comment 32

•

7 years ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/38889a153f45

Status: NEW → RESOLVED

Closed: 7 years ago

status-firefox55: affected → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla55

Ryan VanderMeulen [:RyanVM]

Comment 33

•

7 years ago

Please request Aurora approval on this.

status-firefox52: --- → unaffected

status-firefox-esr52: --- → unaffected

tracking-firefox55: --- → ?

Flags: needinfo?(jcoppeard)

Jon Coppeard (:jonco)

Assignee

Comment 34

•

7 years ago

Comment on attachment 8857000 [details] [diff] [review]
bug1337578-mark-fun-atom

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1324002.
[User impact if declined]: Possible crash.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Simple change to mark atoms when they're assigned in functions.
[String changes made/needed]: None.

Flags: needinfo?(jcoppeard)

Attachment #8857000 - Flags: approval-mozilla-aurora?

Marcia Knous [:marcia]

Comment 35

•

7 years ago

Tracking 54/55+ for this issue.

tracking-firefox54: ? → +

tracking-firefox55: ? → +

Gerry Chang [:gchang]

Comment 36

•

7 years ago

Comment on attachment 8857000 [details] [diff] [review]
bug1337578-mark-fun-atom

Fix a crash. Aurora54+.

Attachment #8857000 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Ryan VanderMeulen [:RyanVM]

Comment 37

•

7 years ago

bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/812a8c51cc98

status-firefox54: affected → fixed

Joel Maher ( :jmaher ) (UTC -8)

Updated

•

7 years ago

Whiteboard: [stockwell needswork] → [stockwell fixed]

Comment hidden (Intermittent Failures Robot)

42 failures in 894 pushes (0.047 failures/push) were associated with this bug in the last 7 days. 

This is the #34 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 24
* mozilla-inbound: 12
* mozilla-central: 6

Platform breakdown:
* osx-10-10: 18
* windows8-64: 6
* windows7-32-vm: 6
* linux64: 6
* linux32: 6

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1337578&startday=2017-04-10&endday=2017-04-16&tree=all

Andrew McCreight [:mccr8]

Comment 39

•

7 years ago

Last instance of this was on the 13th according to Orange Factor so it looks like the patch fixed all of these. Awesome!