Closed Bug 1337645 Opened 3 years ago Closed 3 years ago

fennec l10n bumper script

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
Tracking Status
firefox54 --- fixed

People

(Reporter: aki, Assigned: aki)

References

Details

Attachments

(1 file)

This should take the beta / release changesets for Fennec and land them in-tree.

The first function should generate the patch. A second function should attempt to commit and push -- we can use hgtool or the like. In the future, we can use the first function and send the patch to vcspush scriptworker.

We'll need a looped push like https://hg.mozilla.org/build/mozharness/file/de9295df9085/scripts/bump_gaia_json.py#l189 or https://hg.mozilla.org/build/tools/file/tip/lib/python/util/hg.py#l536
Blocks: 1337825
Blocks: 1337875
Assignee: nobody → aki
Comment on attachment 8835122 [details]
bug 1337645 - add an l10n bumper for fennec relpro.

https://reviewboard.mozilla.org/r/110818/#review112414

::: testing/mozharness/scripts/l10n_bumper.py:74
(Diff revision 1)
> +            ),
> +        })
> +        self.abs_dirs = abs_dirs
> +        return self.abs_dirs
> +
> +    def hg_add(self, repo_path, path):

Is this used? It looks like we can remove it safely.

::: testing/mozharness/scripts/l10n_bumper.py:119
(Diff revision 1)
> +        return True
> +
> +    def _read_json(self, path):
> +        if not os.path.exists(path):
> +            self.error("%s doesn't exist!" % path)
> +            return

This check looks redundant to me. Feel free to remove this block.
Attachment #8835122 - Flags: review?(rail) → review+
Pushed by asasaki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3a29bb4c502e
add an l10n bumper for fennec relpro. r=rail
https://hg.mozilla.org/mozilla-central/rev/3a29bb4c502e
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Blocks: 1339142
Blocks: 1339641
You need to log in before you can comment on or make changes to this bug.