Closed Bug 1337654 Opened 7 years ago Closed 7 years ago

MP4Demuxer::mResource is useless

Categories

(Core :: Audio/Video: Playback, defect)

Product:
Core
Component:
Audio/Video: Playback
Version:
53 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: mozbugz, Assigned: mozbugz)

Details

The MP4Demuxer::mResource RefPtr is set once with a MediaResource and then never used.
That MediaResource is also stored in a RefPtr inside MP4Demuxer::mStream, therefore its lifetime will not be shortened.

So we can just get rid of MP4Demuxer::mResource.
My mistake, it's actually used from MP4TrackDemuxer. I forgot to save a file before compiling, d'oh!
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.