do less copying when dispatching FontFaceLoadingEvents

RESOLVED FIXED in Firefox 54

Status

()

Core
DOM: CSS Object Model
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: heycam, Assigned: heycam)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

When we dispatch loadingdone and loadingerror errors to a FontFaceSet, we do some copying into the event init dictionary's array, when we should be able to just move the arrays we've built up instead.
Created attachment 8834773 [details] [diff] [review]
patch

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1d7db0767563d77dc0082513d8cd581ebf10fcbf&group_state=expanded
Assignee: nobody → cam
Status: NEW → ASSIGNED
Attachment #8834773 - Flags: review?(bzbarsky)
Comment on attachment 8834773 [details] [diff] [review]
patch

r=me
Attachment #8834773 - Flags: review?(bzbarsky) → review+
Keywords: checkin-needed

Comment 3

10 months ago
Pushed by ihsiao@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d286cc530247
Do less copying when dispatching FontFaceLoadingEvents. r=bz
Keywords: checkin-needed

Comment 4

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d286cc530247
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.