1337683 - Match-count limit should be higher/removed/opt-out

Status: NEW

(Toolkit :: Find Toolbar, defect)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've just encountered the "More than 1000 matches" message in the find bar.

I wanted to use the "i of n matches" counter while chatting with someone online about a webpage (e.g., "now look at the 376th occurence of 'e'").

Is this limit really necessary? (There were only 1049 matches in my case!)

If it's CPU-bound, could it instead be limited by the time spent calculating it? So it would naturally scale with the hardware-du-jour.

Finally, could there be an easy opt-out option, e.g.: There could be a "Count more matches..." button that forces the count with a higher limit, say 10x the previous one.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Though I admit I don't know anything about this code, how is the current match identified (when going to the previous/next one) if not by index?
And even if there is some dark pointer magic involved, wouldn't it be possible to keep a running index while iterating over them, e.g. "254 of more than 1000 matches"?