1337698 - Use UniquePtr instead of nsAutoPtr in editor

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1337698 - Part 1. PlaceholderTransaction should use UniquePtr.

Review commit: https://reviewboard.mozilla.org/r/110640/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110640/

Comment 2

[Makoto Kato [:m_kato]]

Attachment: Bug 1337698 - Part 2. HTMLEditor should use UniquePtr.

Review commit: https://reviewboard.mozilla.org/r/110642/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110642/

Comment 3

[Makoto Kato [:m_kato]]

Attachment: Bug 1337698 - Part 3. TypeInState should use UniquePtr.

Review commit: https://reviewboard.mozilla.org/r/110644/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110644/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Comment on attachment 8834806 [details]
Bug 1337698 - Part 1. PlaceholderTransaction should use UniquePtr.

https://reviewboard.mozilla.org/r/110640/#review111928

::: editor/libeditor/PlaceholderTransaction.h:16
(Diff revision 1)
>  #include "nsIAbsorbingTransaction.h"
>  #include "nsIDOMNode.h"
>  #include "nsCOMPtr.h"
>  #include "nsWeakPtr.h"
>  #include "nsWeakReference.h"
> -#include "nsAutoPtr.h"
> +#include "mozilla/UniquePtr.h"

Move this line below "mozilla/EditorUtils.h".

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Comment on attachment 8834807 [details]
Bug 1337698 - Part 2. HTMLEditor should use UniquePtr.

https://reviewboard.mozilla.org/r/110642/#review111930

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Comment on attachment 8834808 [details]
Bug 1337698 - Part 3. TypeInState should use UniquePtr.

https://reviewboard.mozilla.org/r/110644/#review111932

::: editor/libeditor/HTMLEditRules.cpp:4503
(Diff revision 1)
> -  nsAutoPtr<PropItem> item(mHTMLEditor->mTypeInState->TakeClearProperty());
> +  UniquePtr<PropItem> item(
> +    Move(mHTMLEditor->mTypeInState->TakeClearProperty()));

Using "=" might be easier to understand even with the line break, but up to you.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a13c6b029abe
Part 1. PlaceholderTransaction should use UniquePtr. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/4748eeef4625
Part 2. HTMLEditor should use UniquePtr. r=masayuki
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b25ddd519bb
Part 3. TypeInState should use UniquePtr. r=masayuki

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a13c6b029abe
https://hg.mozilla.org/mozilla-central/rev/4748eeef4625
https://hg.mozilla.org/mozilla-central/rev/5b25ddd519bb