Make some methods in editor take Widget*Event instead of nsIDOM*Event as their arguments

RESOLVED FIXED in Firefox 54

Status

()

Core
Editor
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(10 attachments)

59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
59 bytes, text/x-review-board-request
m_kato
: review+
Details | Review
Comment hidden (empty)
Depends on: 1337739
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 12

a year ago
mozreview-review
Comment on attachment 8835384 [details]
Bug 1337718 part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111078/#review112706
Attachment #8835384 - Flags: review?(m_kato) → review+

Comment 13

a year ago
mozreview-review
Comment on attachment 8835385 [details]
Bug 1337718 part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111080/#review112718
Attachment #8835385 - Flags: review?(m_kato) → review+

Comment 14

a year ago
mozreview-review
Comment on attachment 8835386 [details]
Bug 1337718 part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111082/#review112720
Attachment #8835386 - Flags: review?(m_kato) → review+

Comment 15

a year ago
mozreview-review
Comment on attachment 8835387 [details]
Bug 1337718 part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111084/#review112722
Attachment #8835387 - Flags: review?(m_kato) → review+

Comment 16

a year ago
mozreview-review
Comment on attachment 8835388 [details]
Bug 1337718 part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111086/#review112724
Attachment #8835388 - Flags: review?(m_kato) → review+

Comment 17

a year ago
mozreview-review
Comment on attachment 8835389 [details]
Bug 1337718 part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111088/#review112736
Attachment #8835389 - Flags: review?(m_kato) → review+

Comment 18

a year ago
mozreview-review
Comment on attachment 8835390 [details]
Bug 1337718 part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent

https://reviewboard.mozilla.org/r/111090/#review112738
Attachment #8835390 - Flags: review?(m_kato) → review+

Comment 19

a year ago
mozreview-review
Comment on attachment 8835391 [details]
Bug 1337718 part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent*

https://reviewboard.mozilla.org/r/111092/#review112740
Attachment #8835391 - Flags: review?(m_kato) → review+

Comment 20

a year ago
mozreview-review
Comment on attachment 8835392 [details]
Bug 1337718 part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent*

https://reviewboard.mozilla.org/r/111094/#review112742
Attachment #8835392 - Flags: review?(m_kato) → review+

Comment 21

a year ago
mozreview-review
Comment on attachment 8835393 [details]
Bug 1337718 part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible

https://reviewboard.mozilla.org/r/111096/#review112744
Attachment #8835393 - Flags: review?(m_kato) → review+

Comment 22

a year ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/2888f135c737
part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a07723fd11f1
part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/331fad29a7c4
part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/51f5c75cfb6e
part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f49e57b87a0b
part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b12925eebad7
part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b8fb46941569
part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e1f009677c72
part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/942fedc10653
part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3f4ac53f2225
part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible r=m_kato
You need to log in before you can comment on or make changes to this bug.