1337718 - Make some methods in editor take Widget*Event instead of nsIDOM*Event as their arguments

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=79a0011de9a3

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

Review commit: https://reviewboard.mozilla.org/r/111078/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111078/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

Review commit: https://reviewboard.mozilla.org/r/111080/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111080/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

Review commit: https://reviewboard.mozilla.org/r/111082/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111082/

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

Review commit: https://reviewboard.mozilla.org/r/111084/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111084/

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

Additionally, this patch removes unnecessary name space wrapper of IsCtrlShiftPressed().  Perhaps, it was necessary when mozilla::EditorEventListener was nsEditorEventListener.

Review commit: https://reviewboard.mozilla.org/r/111086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111086/

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

Review commit: https://reviewboard.mozilla.org/r/111088/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111088/

Comment 8

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent

Review commit: https://reviewboard.mozilla.org/r/111090/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111090/

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent*

Review commit: https://reviewboard.mozilla.org/r/111092/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111092/

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent*

Review commit: https://reviewboard.mozilla.org/r/111094/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111094/

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)(PTO: 9/8)]

Attachment: Bug 1337718 part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible

Review commit: https://reviewboard.mozilla.org/r/111096/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111096/

Comment 12

[Makoto Kato [:m_kato]]

Comment on attachment 8835384 [details]
Bug 1337718 part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111078/#review112706

Comment 13

[Makoto Kato [:m_kato]]

Comment on attachment 8835385 [details]
Bug 1337718 part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111080/#review112718

Comment 14

[Makoto Kato [:m_kato]]

Comment on attachment 8835386 [details]
Bug 1337718 part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111082/#review112720

Comment 15

[Makoto Kato [:m_kato]]

Comment on attachment 8835387 [details]
Bug 1337718 part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111084/#review112722

Comment 16

[Makoto Kato [:m_kato]]

Comment on attachment 8835388 [details]
Bug 1337718 part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111086/#review112724

Comment 17

[Makoto Kato [:m_kato]]

Comment on attachment 8835389 [details]
Bug 1337718 part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent*

https://reviewboard.mozilla.org/r/111088/#review112736

Comment 18

[Makoto Kato [:m_kato]]

Comment on attachment 8835390 [details]
Bug 1337718 part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent

https://reviewboard.mozilla.org/r/111090/#review112738

Comment 19

[Makoto Kato [:m_kato]]

Comment on attachment 8835391 [details]
Bug 1337718 part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent*

https://reviewboard.mozilla.org/r/111092/#review112740

Comment 20

[Makoto Kato [:m_kato]]

Comment on attachment 8835392 [details]
Bug 1337718 part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent*

https://reviewboard.mozilla.org/r/111094/#review112742

Comment 21

[Makoto Kato [:m_kato]]

Comment on attachment 8835393 [details]
Bug 1337718 part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible

https://reviewboard.mozilla.org/r/111096/#review112744

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2888f135c737
part.1 Make EditorBase::HandleKeyPressEvent() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a07723fd11f1
part.2 Make EditorEventListener::ShouldHandleNativeKeyBindings() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/331fad29a7c4
part.3 Make EditorEventListener::KeyPress() take WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/51f5c75cfb6e
part.4 Make EditorEventListener::KeyUp() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/f49e57b87a0b
part.5 Make IsCtrlShiftPressed() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b12925eebad7
part.6 Make EditorEventListener::KeyDown() take const WidgetKeyboardEvent* instead of nsIDOMKeyEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/b8fb46941569
part.7 Make IMEStateManager::OnMouseButtonEventInEditor() take WidgetMouseEvent* instead of nsIDOMMouseEvent r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e1f009677c72
part.8 Make EditorEventListener::NotifyIMEOfMouseButtonEvent() take WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/942fedc10653
part.9 Make IMEStateManager::OnClickInEditor() take const WidgetMouseEvent* instead of nsIDOMMouseEvent* r=m_kato
https://hg.mozilla.org/integration/autoland/rev/3f4ac53f2225
part.10 Make EditorEventListener::MouseClick() and EditorEventListener::HandleMiddleClickPaste() use WidgetMouseEvent as far as possible r=m_kato

Comment 23

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2888f135c737
https://hg.mozilla.org/mozilla-central/rev/a07723fd11f1
https://hg.mozilla.org/mozilla-central/rev/331fad29a7c4
https://hg.mozilla.org/mozilla-central/rev/51f5c75cfb6e
https://hg.mozilla.org/mozilla-central/rev/f49e57b87a0b
https://hg.mozilla.org/mozilla-central/rev/b12925eebad7
https://hg.mozilla.org/mozilla-central/rev/b8fb46941569
https://hg.mozilla.org/mozilla-central/rev/e1f009677c72
https://hg.mozilla.org/mozilla-central/rev/942fedc10653
https://hg.mozilla.org/mozilla-central/rev/3f4ac53f2225