Move security-prefs.js from netwerk/ to security/manager/

RESOLVED FIXED in Firefox 54

Status

()

Core
Security: PSM
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: emk, Assigned: emk)

Tracking

50 Branch
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Because it is a more logical place.
(Assignee)

Updated

a year ago
Summary: Move security-prefs.js from /netwerk to /security/manager → Move security-prefs.js from netwerk/ to security/manager/
Comment hidden (mozreview-request)

Comment 2

a year ago
mozreview-review
Comment on attachment 8834857 [details]
Bug 1337748 - Move security-prefs.js from netwerk/ to security/manager/.

https://reviewboard.mozilla.org/r/110678/#review112198

Sounds good to me, but we should see if :mcmanus has any objections.
Attachment #8834857 - Flags: review?(dkeeler) → review+
Attachment #8834857 - Flags: review?(mcmanus)

Comment 3

11 months ago
mozreview-review
Comment on attachment 8834857 [details]
Bug 1337748 - Move security-prefs.js from netwerk/ to security/manager/.

https://reviewboard.mozilla.org/r/110678/#review112490
Attachment #8834857 - Flags: review?(mcmanus) → review+

Comment 4

11 months ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/e887fb5d5d06
Move security-prefs.js from netwerk/ to security/manager/. r=keeler,mcmanus

Comment 5

11 months ago
Sorry had to back this out for eslint failure, https://treeherder.mozilla.org/logviewer.html#?job_id=76208920&repo=autoland&lineNumber=8468
Flags: needinfo?(VYV03354)
(Assignee)

Comment 6

11 months ago
Oops. netwerk/ is whitelisted, but security/manager/ is not. And eslint does not know about directives such as |#ifdef|.
Flags: needinfo?(VYV03354)
Comment hidden (mozreview-request)

Comment 8

11 months ago
Backout by cbook@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/496d69070607
Backed out changeset e887fb5d5d06 for eslint failure

Comment 9

11 months ago
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/d84bc5495deb
Move security-prefs.js from netwerk/ to security/manager/. r=keeler,mcmanus

Comment 10

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d84bc5495deb
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.