Closed Bug 1337764 Opened 7 years ago Closed 7 years ago

Attach In stub for proxies

Categories

(Core :: JavaScript Engine: JIT, defect, P3)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1357759
Project Flags:
Performance Impact low

People

(Reporter: evilpie, Assigned: tcampbell)

References

(Blocks 1 open bug)

Details

ArrayMap and others are used with NodeLists, which are proxies. But I also see normal property names with |in| and proxies. So we should just optimize values in general.
Priority: -- → P3
Whiteboard: [qf:p3]
Can you explain the issue here in more detail?  I don't understand what the issue is.
Flags: needinfo?(evilpies)
https://searchfox.org/mozilla-central/source/js/src/jit/CacheIR.cpp#1843

We currently fail to attach ICs for JSOP_IN for most things that are not NativeObject (such as proxies). Tom proposed we should extend InIRGenerator::tryAttachStub since the proxy case occurs in the wild.
Flags: needinfo?(evilpies)
This would be almost identical to this patch: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9d036ef05e8. Maybe we should look into unify hasOwnProperty an |in|.
Sorry, this was meant for bug 1337773. But I actually wrote code for Proxy with hasOwnProperty as well: https://hg.mozilla.org/integration/mozilla-inbound/rev/d505fbfbd4e2
Assignee: nobody → tcampbell
Status: NEW → ASSIGNED
This work is merged into Bug 1357759
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Performance Impact: --- → P3
Whiteboard: [qf:p3]
You need to log in before you can comment on or make changes to this bug.