1337765 - dist/include/mozilla/RefPtr.h:40:11: error: invalid use of incomplete type 'class mozilla::dom::Promise' (non-SPS)

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jan Beich]

In file included from objdir/dom/ipc/Unified_cpp_dom_ipc0.cpp:2:
In file included from dom/ipc/ColorPickerParent.cpp:7:
In file included from dom/ipc/ColorPickerParent.h:10:
In file included from objdir/ipc/ipdl/_ipdlheaders/mozilla/dom/PColorPickerParent.h:9:
In file included from objdir/ipc/ipdl/_ipdlheaders/mozilla/dom/PColorPicker.h:11:
In file included from objdir/dist/include/ipc/IPCMessageUtils.h:11:
In file included from ipc/chromium/src/chrome/common/ipc_message_utils.h:20:
In file included from ipc/chromium/src/chrome/common/file_descriptor_set_posix.h:14:
In file included from objdir/dist/include/nsISupportsImpl.h:14:
In file included from objdir/dist/include/nsISupportsUtils.h:15:
objdir/dist/include/mozilla/RefPtr.h:40:9: error: member access into incomplete type
      'mozilla::dom::Promise'
    aPtr->Release();
        ^
objdir/dist/include/mozilla/RefPtr.h:394:33: note: in instantiation of member function
      'mozilla::RefPtrTraits<mozilla::dom::Promise>::Release' requested here
      mozilla::RefPtrTraits<U>::Release(aPtr);
                                ^
objdir/dist/include/mozilla/RefPtr.h:78:37: note: in instantiation of member function
      'RefPtr<mozilla::dom::Promise>::ConstRemovingRefPtrTraits<mozilla::dom::Promise>::Release'
      requested here
      ConstRemovingRefPtrTraits<T>::Release(mRawPtr);
                                    ^
objdir/dist/include/mozilla/dom/FileCreatorHelper.h:75:3: note: in instantiation of member
      function 'RefPtr<mozilla::dom::Promise>::~RefPtr' requested here
  ~FileCreatorHelper() = default;
  ^
objdir/dist/include/GeckoProfiler.h:68:7: note: forward declaration of
      'mozilla::dom::Promise'
class Promise;
      ^
1 error generated.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: compile.patch

Comment 2

[Jan Beich]

Attachment: Bug 1337765 - Unbreak build on non-SPS platforms after bug 1335536.

Review commit: https://reviewboard.mozilla.org/r/110686/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/110686/

Comment 3

[Andrea Marchesini [:baku]]

Comment on attachment 8834885 [details]
Bug 1337765 - Unbreak build on non-SPS platforms after bug 1335536.

https://reviewboard.mozilla.org/r/110686/#review111960

Thanks for this patch. But I would like to keep Promise.h out of FileCreatorHelper. I actually submitted a patch. Do you mind to test it?

Comment 4

[Jan Beich]

Comment on attachment 8834885 [details]
Bug 1337765 - Unbreak build on non-SPS platforms after bug 1335536.

Sorry, I forgot to cancel my version.

Comment 5

[Jan Beich]

Comment on attachment 8834884 [details] [diff] [review]
compile.patch

My clobber build went fine. Thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de2aed4a9ab2
Fix a compilation issue in FileCreatorHelper, r=qdot, f=jbeich

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de2aed4a9ab2