CacheIR: consider passing GetElem/SetElem key as argument

NEW
Unassigned

Status

()

P3
normal
2 years ago
a year ago

People

(Reporter: jandem, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qf-])

(Reporter)

Description

2 years ago
GetPropIRGenerator and SetPropIRGenerator currently call {g,s}etElemKeyValueId to get the key's OperandId.

It might be nicer to pass it explicitly to the try* methods as Maybe<ValOperandId> and then pass it to maybeEmitIdGuard. Maybe<> because we don't have a key id when it's a GetProp/SetProp IC.
Priority: -- → P3
Whiteboard: [qf-]
Bug 1169745 adds similar get/set for super receiver and should be cleaned up at same time.
You need to log in before you can comment on or make changes to this bug.