1337822 - Make SearchEngines.getUnorderedBundledEngines more robust

Status: RESOLVED DUPLICATE of bug 1354934

(Firefox for iOS :: General, defect, P3)

Description

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

At the end of getUnorderedBundledEngines() there is a forced unwrap, which can trigger a crash if the call above to parser.parse() failed.

It is better to not show the search engine than to crash.

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: Crash report

Comment 2

[Jacob White]

Attachment: Pull Request

Comment 3

[Jacob White]

Comment on attachment 8846830 [details] [review]
Pull Request

https://github.com/mozilla-mobile/firefox-ios/pull/2517

pull request from master.

Comment 4

[Emily Toop (:fluffyemily)]

Comment on attachment 8846830 [details] [review]
Pull Request

The fix looks good, but as it's really hard to test I'd like to see a unit test added that demonstrates that the correct response of not adding the corrupted engine actually occurs.

Comment 5

[Jacob White]

It's my understanding that if the parser.parse function can't parse the search engine it will return nil. Presumably if that function has a bug where it returns a malformed search engine, that would be a different bug. This fix just prevents ff from crashing when the parser can't parse a given search engine.