[one-click loaner] Setup mach binary in one-click loaner even when choosing option 1 in the wizard

RESOLVED FIXED in Firefox 54

Status

Testing
General
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: ahal, Assigned: ahal)

Tracking

unspecified
mozilla54
Points:
---

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Assignee)

Description

a year ago
Currently the 'run-wizard' script will only set up mach if you choose option 2. This means if you choose option 1, then Ctrl-C and want to start over, you won't be able to without re-running the wizard.

We should catch Ctrl-C in the run-wizard script, check to see if 'mach' exists, and link it if it does.
(Assignee)

Updated

a year ago
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Comment hidden (mozreview-request)
Comment on attachment 8835493 [details]
Bug 1337827 - [one-click-loaner] Print error message if mach binary wasn't found

I am not familiar with this code, nor do I really follow the changes- I would prefer if someone else could review this as a rubber stamp is all I can give (and would be happy to)
Attachment #8835493 - Flags: review?(jmaher)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
No worries, I got Maja to volunteer. And you're right it was kind of tricky to see what the change was about.

Maja: I split it up and added a more detailed commit message so it's hopefully easier to follow now. I'm also happy to explain things further.. just ping me on irc if you want more clarification.
(Assignee)

Updated

a year ago
Attachment #8836126 - Flags: review?(mjzffr)
Attachment #8835493 - Flags: review?(mjzffr)
Attachment #8836127 - Flags: review?(mjzffr)

Comment 7

a year ago
mozreview-review
Comment on attachment 8835493 [details]
Bug 1337827 - [one-click-loaner] Print error message if mach binary wasn't found

https://reviewboard.mozilla.org/r/111226/#review113678
Attachment #8835493 - Flags: review?(mjzffr) → review+

Comment 8

a year ago
mozreview-review
Comment on attachment 8836126 [details]
Bug 1337827 - [one-click-loaner] Refactor mach environment setup into a standalone function

https://reviewboard.mozilla.org/r/111572/#review113680
Attachment #8836126 - Flags: review?(mjzffr) → review+

Comment 9

a year ago
mozreview-review
Comment on attachment 8836127 [details]
Bug 1337827 - [one-click-loaner] Always set up mach environment when calling 'run-mozharness' (if possible)

https://reviewboard.mozilla.org/r/111574/#review113682
Attachment #8836127 - Flags: review?(mjzffr) → review+
(In reply to Andrew Halberstadt [:ahal] from comment #6)
> No worries, I got Maja to volunteer. And you're right it was kind of tricky
> to see what the change was about.
> 
> Maja: I split it up and added a more detailed commit message so it's
> hopefully easier to follow now. I'm also happy to explain things further..
> just ping me on irc if you want more clarification.

It all made sense, thanks. Sorry for the delayed reply.
(Assignee)

Comment 11

a year ago
Thanks, no problem! A turn around time of ~1 workday is hardly a delay

Comment 12

a year ago
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9ba825a65a34
[one-click-loaner] Refactor mach environment setup into a standalone function r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/b3c43c86a86b
[one-click-loaner] Print error message if mach binary wasn't found r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/8c97b432e7c5
[one-click-loaner] Always set up mach environment when calling 'run-mozharness' (if possible) r=maja_zf

Comment 13

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ba825a65a34
https://hg.mozilla.org/mozilla-central/rev/b3c43c86a86b
https://hg.mozilla.org/mozilla-central/rev/8c97b432e7c5
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.