Closed Bug 1337828 Opened 3 years ago Closed 3 years ago

Improve error messaging when no tests are detected / invalid paths are used

Categories

(Testing :: Mochitest, defect)

defect
Not set

Tracking

(firefox54 fixed)

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: ahal, Assigned: ahal)

Details

Attachments

(2 files)

It can be confusing if you pass in a wrong path combined with a wrong suite/subsuite designation, especially on one-click loaners (the build system TestResolver normally handles edge cases like this when running locally).

The mochitest harness should make it very clear what went wrong and why. We'll want to print a list of absolute paths that tests were searched for in, as well as the active flavor and subsuite. It should also recommend how to fix it (i.e by passing in --flavor).
Comment on attachment 8837142 [details]
Bug 1337828 - Pass unexpected test paths as is from mach_test_package_bootstrap to the test harness,

https://reviewboard.mozilla.org/r/112372/#review113754
Attachment #8837142 - Flags: review?(mjzffr) → review+
Comment on attachment 8837143 [details]
Bug 1337828 - Improve mochitest 'no tests' error message,

https://reviewboard.mozilla.org/r/112374/#review113756
Attachment #8837143 - Flags: review?(mjzffr) → review+
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e725ba1475be
Pass unexpected test paths as is from mach_test_package_bootstrap to the test harness, r=maja_zf
https://hg.mozilla.org/integration/autoland/rev/b83537047757
Improve mochitest 'no tests' error message, r=maja_zf
https://hg.mozilla.org/mozilla-central/rev/e725ba1475be
https://hg.mozilla.org/mozilla-central/rev/b83537047757
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.