1337913 - Corrupted default theme with specific extensions enabled

Status: RESOLVED WORKSFORME

(Firefox :: Extension Compatibility, defect)

Description

[Daniel B.]

Attachment: ff corrupted.png

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

- Create new profile
- Install both Download Cleaner Lite (https://addons.mozilla.org/en-US/firefox/addon/download-cleaner-lite/ - developed by myself) and FlashStopper (https://addons.mozilla.org/en-US/firefox/addon/flashstopper/?src=ss) extensions. 
- Restart Firefox


Actual results:

- "Native" buttons have white font color when focused(?) or hovered, see attached image "ff corrupted.png".
- Window titlebar has wrong color
- Window button (minimize/maximize/close) stroke is thicker (2 pixels instead of 1)
- Some other subtle design changes


Expected results:

No design/theme/color changes whatsoever, see attached image "ff normal.png".

Comment 1

[Daniel B.]

Attachment: ff normal.png

Comment 2

[Loic]

How is it an issue in Firefox? Does it happen with previous versions of Firefox?

Comment 3

[Daniel B.]

? The alert() messagebox is entirely made up of XUL. Using DOM Inspector I can confirm the computed font color changes to white, although the CSS rule still says "color: ButtonText".

It also appears on all other Firefox messageboxes, like the one asking for confirmation to close when multiple tabs are open or the one about setting Firefox as the default browser.

The titlebar, too, is not a native Windows titlebar. (It may be behaving incorrectly in the first place though, seeing how there is no color change between focused and unfocused window states.)

The titlebar issue does exist on 49.0.2, the button label issue does not. On 50.0, both issues exist.

Both issues do not appear on Linux or macOS. They do appear on Windows 8.1 as well.

Comment 4

[Loic]

Is e10s enabled in your Firefox on Windows? (about:support > line 'multiprocess windows')
If yes, could you test with e10s disabled.
https://wiki.mozilla.org/Electrolysis#Firefox_Release

Comment 5

[Daniel B.]

No, it’s not active ("disabled by add-ons"). The author of FlashStopper states on his extension’s page that it is incompatible with e10s.

I forgot to mention that I don’t have any code in my extension that is supposed to interact with messageboxes. And from what I can understand, neither does FlashStopper. They also don’t conflict in what they do.

Comment 6

[u554753]

Reproducible with the following specs: 
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0

But I'm not sure if this would be due to the known incompatibility with e10s.

Comment 7

[LL25255252]

As of now, I know of 3 addons that when installed with Flashstopper cause this dimmed buttons issue.

http://i.imgur.com/zW2en3R.jpg

Download Cleaner Lite 1.2 - https://addons.mozilla.org/en-US/firefox/addon/download-cleaner-lite/

Tab Tally  1.0.0  - https://addons.mozilla.org/en-US/firefox/addon/tab-tally/

Expire history by days  1.3.0 - https://addons.mozilla.org/en-US/firefox/addon/expire-history-by-days/

BTW - don't forget to restart the browser to reproduce the issue.

Tested on a clean/fresh firefox profile
Flashstopper 1.4.5
No e10.
Firefox 52.0.2 (32-bit)
Win 7 x64

Comment 8

[Jorge Villalobos [:jorgev] (he/him)]

This shouldn't happen anymore, since add-ons should be using the WebExtensions API and it shouldn't affect the UI this way. Please reopen if you can reproduce this in current release versions of Firefox.