1337918 - (devtools/auto-completion) [meta] Auto-completion of values is missing for several properties

Status: NEW

(DevTools :: Inspector: Rules, enhancement, P3)

Description

[Sebastian Zartner [:sebo]]

There are several CSS properties, which are missing an auto-completion of their values, like e.g. font-weight.

Sebastian

Comment 1

[Tom Tromey :tromey]

Based on looking at nsCSSPropList.h, I think font-weight will be fixed by the patch
in bug 1106336.  So maybe this should just be closed as a dup?

Comment 2

[Sebastian Zartner [:sebo]]

Bug 1106336 doesn't have a patch yet and is restricted to the 'text-overflow' property. This one is meant as meta-bug for all properties.

Sebastian

Comment 3

[Tom Tromey :tromey]

Oh, sorry about that!  I confused it with the bug where this is being done, namely bug 1156019.
I think that will fix both 1106336 and this bug.

Comment 4

[Tom Tromey :tromey]

I think this bug can probably be closed, but I thought I'd ask first.

Comment 5

[Sebastian Zartner [:sebo]]

While bug 1156019 brought a huge improvement in autocompleting values, there are still a few properties that are missing autocompletion like the 'none' value for 'quotes', for example. I didn't check this in detailed yet, though I'd like to keep this bug open and file more blocking bugs for the missing pieces.

Sebastian

Comment 6

[Tom Tromey :tromey]

(In reply to Sebastian Zartner [:sebo] from comment #5)
> While bug 1156019 brought a huge improvement in autocompleting values, there
> are still a few properties that are missing autocompletion like the 'none'
> value for 'quotes', for example.

Thanks!  I wonder how you found this.

"quotes" has a custom parser:

https://dxr.mozilla.org/mozilla-central/rev/f40e24f40b4c4556944c762d4764eace261297f5/layout/style/nsCSSPropList.h#3551

and it recognizes none here:

https://dxr.mozilla.org/mozilla-central/rev/f40e24f40b4c4556944c762d4764eace261297f5/layout/style/nsCSSParser.cpp#15356

Perhaps all `CSS_PROPERTY_PARSE_FUNCTION` properties ought to be audited; though I wonder
if there's some more future-proof way.

Comment 7

[Sebastian Zartner [:sebo]]

(In reply to Tom Tromey :tromey from comment #6)
> (In reply to Sebastian Zartner [:sebo] from comment #5)
> > While bug 1156019 brought a huge improvement in autocompleting values, there
> > are still a few properties that are missing autocompletion like the 'none'
> > value for 'quotes', for example.
> 
> Thanks!  I wonder how you found this.

In this case simply by trying out the different properties in the DevTools.

> Perhaps all `CSS_PROPERTY_PARSE_FUNCTION` properties ought to be audited;

For now, I think there's no other way to do it.

> though I wonder if there's some more future-proof way.

Maybe the related code could be changed to somehow expose their possible values right in the related parse functions, though I don't really know the code enough to give proper input on this.

Sebastian