Closed Bug 1337926 Opened 7 years ago Closed 7 years ago

mochitest shutdown logspew includes "Exception running bootstrap method shutdown on shield-recipe-client@mozilla.org: ReferenceError: LogManager is not defined (resource://gre/modules/addons/XPIProvider.jsm"

Categories

(Firefox :: Normandy Client, defect)

Product:
Firefox
Component:
Normandy Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1336501

People

(Reporter: dholbert, Unassigned)

Details

STR:
 1. Run a single mochitest-plain test, e.g.
      ./mach mochitest layout/forms/test/test_bug1301290.html
...or:
      ./mach mochitest layout/style/test/test_flexbox_order.html

 2. After the test has completed, close the Firefox window for the test run. (or do Ctrl+Q/Cmd+Q to quit).

 3. Look at your terminalspew.

ACTUAL RESULTS:
This is towards the end of the terminal output, right when I close the window:
{
1486585306871	addons.xpi	WARN	Exception running bootstrap method shutdown on shield-recipe-client@mozilla.org: ReferenceError: LogManager is not defined (resource://gre/modules/addons/XPIProvider.jsm -> file:///scratch/work/builds/mozilla-inbound/obj/dist/bin/browser/features/shield-recipe-client@mozilla.org/bootstrap.js:65:3) JS Stack trace: this.shutdown@resource://gre/modules/addons/XPIProvider.jsm -> file:///scratch/work/builds/mozilla-inbound/obj/dist/bin/browser/features/shield-recipe-client@bootstrap.js:65:3 < callBootstrapMethod@XPIProvider.jsm:4903:11 < observe@XPIProvider.jsm:2884:15
}

EXPECTED RESULTS: No such failure.

This seems to come from the "LogManager" usage on this line (line 65):
> 64  this.shutdown = function(data, reason) {
> 65    Preferences.ignore(PREF_LOGGING_LEVEL, LogManager.configure);

That was added pretty recently, as part of this "no bug" changeset:
Mythmon - No bug - Update shield-recipe-client from GitHub r=Gijs
https://hg.mozilla.org/mozilla-central/rev/acd9236e8f36

Mythmon, perhaps you could take a look (or perhaps you know who should take a look)?
Note: I'm hitting this in a debug build on Ubuntu 16.10, with just
 ac_add_options --enable-debug --disable-optimize
as my only mozconfig options.
Looks like this line of code was recently removed from the upstream addon:
https://github.com/mozilla/normandy/commit/f5d8b23d5d903934f72017ad84461a1d800804a3#diff-c8517058b2894b9b51039d3b380c8980L65

Maybe this will be better once we've pulled in that change?
Flags: needinfo?(mcooper)
Yes, the fix from github landed in autoland in bug 1336501. Should be in Nightly tomorrow, I guess. :-)
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(mcooper)
Resolution: --- → DUPLICATE
Product: Shield → Firefox
You need to log in before you can comment on or make changes to this bug.