Closed Bug 1337956 Opened 7 years ago Closed 4 years ago

[eslint] Indentation of array literals in function arguments broken

Categories

(Developer Infrastructure :: Lint and Formatting, defect, P3)

Product:
Developer Infrastructure
Component:
Lint and Formatting
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: kmag, Unassigned)

References

Details

Bug 1326479 upgraded ESLint and changed the indentation options for array literals. One of the results is that indentation for array literals that appear in function arguments is now completely broken. While all other function arguments are expected to start at the same indentation level as the first argument, array arguments now start one indentation level past the start of the previous line, no matter where other arguments are aligned.
ESLint 4.0 has many more indentation options, so that might help this.
Depends on: 1371293
Priority: -- → P3
Product: Testing → Firefox Build System
Summary: Indentation of array literals in function arguments broken → [eslint] Indentation of array literals in function arguments broken

A while ago we switched to Prettier, and so now we have consistent formatting. I've not heard of any issues with this particular item, and we probably wouldn't change it anyway since Prettier doesn't have many config options.

Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → WORKSFORME
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.