133797 - Update the User Agent String for Mozilla 1.0 release

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[lpham]

Need two patches to update the UserAgent string for Mozilla 1.0 release on the
trunk and MOZILLA_1_0_0_BRANCH

This bug must do after Mozilla 1.0 RC1 completes.

Comment 1

[lpham]

Changed the keyword to mozilla1.0 (requested by Asa)

I want to make it clear for this bug. We need two patches for this bug.
-Update UserAgent String on the trunk to 1.0.0+
-Update UserAgent String on MOZILLA_1_0_0_BRANCH to 1.0.0
*must do after releasing Mozilla 1.0 RC1

Comment 2

[Asa Dotzler [:asa]]

must have. mozilla1.0+

Comment 3

[lpham]

Aki,there is some discussion about updating the UserAgent in bug #133794 patch
id=78923 .  I'm not sure they want to do it before RC1 or not.  Please check the
status of bug #133794 before working on this one.  Thanks.

Comment 4

[lpham]

Confirm: this bug still needs to do after RC 1 release.

Comment 5

[Aki Sasaki]

Attachment: branch patch

Comment 6

[Aki Sasaki]

Attachment: trunk patch

Comment 7

[Daniel (Leaf) Nunes]

Comment on attachment 81021 [details] [diff] [review]
branch patch

sr=leaf

Comment 8

[lpham]

Leaf, Do we need to change to rc2 on the branch or just do 1.0.0?  

Comment 9

[lpham]

Comment on attachment 81021 [details] [diff] [review]
branch patch

r=lpham
Aki, don't worry about rc2 for now.  We will have a different bug if we need
for rc2.

Comment 10

[Daniel (Leaf) Nunes]

Comment on attachment 81022 [details] [diff] [review]
trunk patch

sorry, i was waiting for the 1.0.0 final release before super-reviewing this,
but that's not what we usually do anyway. sr=leaf

Comment 11

[lpham]

Comment on attachment 81022 [details] [diff] [review]
trunk patch

look good, r=lpham

Comment 12

[Aki Sasaki]

checked into branch and trunk.

Comment 13

[Jonas Jørgensen]

Sorry for dropping in so late, but I really think you should wait until the last
moment with this change. Remember the incident where a German news site
announced the release of RC 1 before it was released, simply because the about
page said that what they had downloaded was RC 1? We wouldn't want a lot of "1.0
is here!!!" announcements tomorrow, would we?

I strongly suggest you back out the branch patch.

Comment 14

[Aki Sasaki]

branch changed to 1.0rc2.
reopening since i'll have to checkin 1.0.0 change after rc2, close to 1.0 release.

Comment 15

[lpham]

Thanks Aki for quick response and changing to rc2.
Loan

Comment 16

[Jacek Piskozub]

Jonas: If you look at http://www.mozilla.org/roadmap.html, you'll see that
around May 22 we will have mozilla1.1alpha on the trunk. At the time final
mozilla1.0 may still be not released! 

Confusion is hard to avoid in the situation of branch heading for 1.0 final and
trunk for 1.1alpha but this is no reason for calling the trunk 0.9.9+ _after_
1.0 branched.

Comment 17

[Aki Sasaki]

jacek:  the trunk wasn't backed out, and it's at 1.0.0+
the change only occurred on the branch.

Comment 18

[Jonas Jørgensen]

> Jonas: [...] this is no reason for calling the trunk 0.9.9+ _after_ 1.0 branched.

Agreed -- that's why I said "I strongly suggest you back out the *branch* patch"
(emphasis added) :-)

Comment 19

[Aki Sasaki]

since I did actually update the UserAgent string on the trunk and branch after
rc1, I'm going to call this one fixed and we can open a new bug for the actual
release.

Comment 20

[lpham]

Aki, Please submit the patch to update UserAgent string for Mozilla 1.0 RC3. Thanks.

Comment 21

[Aki Sasaki]

Attachment: rc3 branch patch

Comment 22

[lpham]

Look good r=lpham

Comment 23

[Daniel (Leaf) Nunes]

Comment on attachment 83614 [details] [diff] [review]
rc3 branch patch

amen, sr=leaf

Comment 24

[Aki Sasaki]

checked in. guessing we'll reopen for 1.0rtm/rc4/whatever.

Comment 25

[lpham]

Aki, you're right.  Now is the time to submit the patch for Mozilla 1.0 release.
 Please try to complete it today so the build tomorrow will be Mozilla 1.0
Thanks.

Comment 26

[lpham]

Aki already had the patch #81021 and got r= and sr=.  Aki will check it in when
the branch tree is open.  Loan

Comment 27

[Stephan Hohe]

The User Agent string was already updated yesterday by Leaf (see bonsai or
<http://lxr.mozilla.org/mozilla1.0/source/modules/libpref/src/init/all.js#46>)

Comment 28

[lpham]

Yeah.  Leaf is a head of me.  Thanks for your info.  I close the bug.

Comment 29

[Jon Granrose]

verified.