1337970 - Over-escaping in commit message tooltips

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

If I hover over the "part 3" commit at https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=28e96f6befceda3ebcb0f2ad6068f61900013fa6

The tooltip is overescaped.

Comment 1

[Boris Zbarsky [:bzbarsky]]

The part 3 commit for bug 1332956, that is.

Comment 2

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:escapetooltip > mozilla:master

Comment 3

[GitHub Autolander Bot]

Attachment: [treeherder] KWierso:escapetooltip > mozilla:master

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Comment on attachment 8835198 [details] [review]
[treeherder] KWierso:escapetooltip > mozilla:master

Testing locally, this PR fixes the overescaping for me.

Testing on the 'effda19da482' revision's message at http://localhost:8000/#/jobs?repo=autoland&revision=62ffc0541c4d755199b313b0eed361f9e2c985ab&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified it doesn't appear to render it as HTML. Hopefully that means it's safe enough?

Comment 5

[Ed Morley [:emorley]]

Comment on attachment 8835198 [details] [review]
[treeherder] KWierso:escapetooltip > mozilla:master

Cameron reviewed this code initially, I'll defer to him :-)

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/98f7d3fe97079218cf156029cb02c0963c41613e
Bug 1337970 - Unescape commit message tooltips (#2148) r=camd