Closed
Bug 1338038
Opened 8 years ago
Closed 7 years ago
Intermittent browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js | recording-device-events notification unexpected - Got -1, expected 0
Categories
(Core :: WebRTC, defect, P2)
Core
WebRTC
Tracking
()
RESOLVED
DUPLICATE
of bug 1363253
People
(Reporter: intermittent-bug-filer, Unassigned)
References
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])
Attachments
(1 file)
1.36 KB,
patch
|
gbrown
:
review+
|
Details | Diff | Splinter Review |
Filed by: philringnalda [at] gmail.com
https://treeherder.mozilla.org/logviewer.html#?job_id=75767210&repo=mozilla-central
https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win64-pgo/1486600214/mozilla-central_win8_64_test_pgo-mochitest-browser-chrome-3-bm112-tests1-windows-build81.txt.gz
Comment hidden (Intermittent Failures Robot) |
Updated•8 years ago
|
Comment 2•8 years ago
|
||
These failures started after the fix in bug 1323880 landed.
Several of these failures were associated to bug 1324303.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 5•8 years ago
|
||
:florian, can you take a look at fixing this or helping find somebody to look at this?
Flags: needinfo?(florian)
Whiteboard: [stockwell needswork]
Comment 6•8 years ago
|
||
(In reply to Joel Maher ( :jmaher) from comment #5)
> :florian, can you take a look at fixing this or helping find somebody to
> look at this?
I can investigate a bit. But given how often bug 1324303 occurs, and given that I don't see any progress on fixing bug 1320994, it may be time to start writing code to make the test skip the recording-device-events notification check on some platforms; so that we keep most of the coverage but stop being bothered by the intermittent behavior.
Flags: needinfo?(florian)
Comment 7•8 years ago
|
||
both bug 1324303 and this one are past our 30/week threshold where we want to see a fix. This bug fails on win8 primarily and bug 1324303 more on linux. What help would you need in this? These failures have been constant for 2+ weeks :(
Comment 8•8 years ago
|
||
Andreas, is there any chance of seeing progress in bug 1320994 soon, or should we write code to skip the recording-device-events notification check on Windows64 and Linux?
Flags: needinfo?(pehrson)
Comment 9•8 years ago
|
||
I'm a bit swamped at the moment but I can prioritise it and take a look in a week or so.
Flags: needinfo?(pehrson)
Updated•8 years ago
|
Comment 10•8 years ago
|
||
Thanks Andreas for pointing at a root cause- I understand you are busy- if we focus on the root cause, can we partially disable this in the mean time and add a comment to bug 1320994 to ensure that we backout the disabling?
Comment 11•8 years ago
|
||
The biggest problem with that is that it might never get fixed since it's not an immediate problem anymore. There are always other problems that seem immediate, and suddenly you've forgotten about it. I guess it's up to you to weigh the cost of keeping it around for another two something weeks against keeping it around for a much longer time.
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 14•8 years ago
|
||
when there is time to fix this we hope to see this enabled again soon!
Attachment #8847189 -
Flags: review?(gbrown)
Comment 15•8 years ago
|
||
this will fix this for bug 1324303 as well.
Updated•8 years ago
|
Attachment #8847189 -
Flags: review?(gbrown) → review+
Comment 16•8 years ago
|
||
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a37f9e1cbc8f
Intermittent browser/base/content/test/webrtc/browser_devices_get_user_media_screen.js. r=gbrown
Updated•8 years ago
|
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
Comment 17•8 years ago
|
||
bugherder |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 23•7 years ago
|
||
I have patches on bug 1363253 that I hope will fix this.
See Also: → 1363253
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
Updated•7 years ago
|
Whiteboard: [stockwell disabled] → [stockwell fixed]
Comment hidden (Intermittent Failures Robot) |
Comment 26•7 years ago
|
||
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
You need to log in
before you can comment on or make changes to this bug.
Description
•