1338047 - Migrate all taskcluster-lib-* libraries to use import/export syntax

Status: RESOLVED INVALID

(Taskcluster :: Services, defect)

Description

[Jonas Finnemann Jensen (:jonasfj)]

This might be a good first bug.
Do one at the time... And probably upgrade downstream repositories using the libraries as well.

It's important to identify any difference in semantics when doing this.
I'm pretty sure there is a difference when we do:
  import abc from 'abc';
in some downstream projects already.
Hence, doing doing 'export ...' only statements might not be enough, we probably
need to defined 'export default' to avoid problems.

Comment 1

[Jonas Finnemann Jensen (:jonasfj)]

Before picking this as a bug, probably ask on #tc-contributors or #taskcluster, and we'll file a specific bug for specific service or library. One at the time is a good way consume cookies and bugs alike :)

Comment 2

[Yashvardhan Didwania [:ydidwania]]

Hi, I would like to work on this bug. I have a limited experience of JS.

Comment 3

[Yashvardhan Didwania [:ydidwania]]

I read up about the difference in the two syntax. I think now I can work on this.
I didn't find the taskcluster-lib-* files in mozilla-central repository. And we don't use github primarily.
So where should I start from?

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

The repositories are on Github.  Firefox itself doesn't use Github primarily, but lots of other Mozilla projects do. I've forgotten which library we talked about starting with, but https://github.com/taskcluster/taskcluster-lib-api is an example.

Comment 5

[Yashvardhan Didwania [:ydidwania]]

I made a PR on github (https://github.com/taskcluster/taskcluster-lib-api/pull/62) . For some reason it does not show up here as attachment. Maybe that is disabled.

I am facing few issues with the file taskcluster-lib-api/test/validate_test.js  which I have mentioned on github.
Kindly take a look.

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

I'm not sure exactly what causes pull requests to be reflected into bugzilla.. sometimes it happens, sometimes it doesn't :)

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

For context, this was resolved as invalid because Node does not yet support import/export, and we want to stop using Babel for our services.  Once this is fully supported in Node, we will start using it.