Closed Bug 1338069 Opened 6 years ago Closed 6 years ago

Don't use window object when using getComputedStyle in dom/animation/test.

Categories

(Core :: DOM: Animation, defect)

Product:
Core
Component:
DOM: Animation
Version:
54 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox54 --- wontfix
firefox55 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

References

Details

Attachments

(1 file)

Bug 1338069 - Don't use 'window' object when using getComputedStyle in tests.
59 bytes, text/x-review-board-request
birtles
: review+
Details 
It's small change.

In bug 1302648, we didn't specify the 'window' object when using getComputedStyle.
For consistency, I drop 'window' object when using getComputedStyle in the animation tests.
I'm not completely sure this is worth doing, at least not for now. There are various upstream changes happening and a big cross-cutting change like this here is going to make merging those really hard work for James. We should probably hold off a couple of weeks.

Also, we need to update the checksums of all these files we're changing by running 'mach web-platform-tests --manifest-update yer' otherwise anyone else running that command on m-c will get a bunch of unrelated changes.
I haven't forgotten about this. I'm just waiting for the latest web-platform-tests sync to hit mozilla central (should be next 1~2 days).
Comment on attachment 8835333 [details]
Bug 1338069 - Don't use 'window' object when using getComputedStyle in tests.

https://reviewboard.mozilla.org/r/111024/#review115298

web-platform-tests has finally been synced so I think this is ok to land.
Attachment #8835333 - Flags: review?(bbirtles) → review+
Mantaroh, are you going to land this?
Flags: needinfo?(mantaroh)
(In reply to Brian Birtles (:birtles) from comment #5)
> Mantaroh, are you going to land this?

Sorry, I forgot to land it.

Try :
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eba443758b0896ec2f0f79c7058cfbb287a545cc
You can specify "--artifact" syntax for test file only changes.  It does not work on stylo for now though.
Assignee: nobody → mantaroh
Flags: needinfo?(mantaroh)
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/c80974470261
Don't use 'window' object when using getComputedStyle in tests. r=birtles
https://hg.mozilla.org/mozilla-central/rev/c80974470261
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.