1338069 - Don't use window object when using getComputedStyle in dom/animation/test.

Status: RESOLVED FIXED

(Core :: DOM: Animation, defect)

Description

[Mantaroh Yoshinaga[:mantaroh]]

It's small change.

In bug 1302648, we didn't specify the 'window' object when using getComputedStyle.
For consistency, I drop 'window' object when using getComputedStyle in the animation tests.

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1338069 - Don't use 'window' object when using getComputedStyle in tests.

Review commit: https://reviewboard.mozilla.org/r/111024/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111024/

Comment 2

[Brian Birtles (:birtles)]

I'm not completely sure this is worth doing, at least not for now. There are various upstream changes happening and a big cross-cutting change like this here is going to make merging those really hard work for James. We should probably hold off a couple of weeks.

Also, we need to update the checksums of all these files we're changing by running 'mach web-platform-tests --manifest-update yer' otherwise anyone else running that command on m-c will get a bunch of unrelated changes.

Comment 3

[Brian Birtles (:birtles)]

I haven't forgotten about this. I'm just waiting for the latest web-platform-tests sync to hit mozilla central (should be next 1~2 days).

Comment 4

[Brian Birtles (:birtles)]

Comment on attachment 8835333 [details]
Bug 1338069 - Don't use 'window' object when using getComputedStyle in tests.

https://reviewboard.mozilla.org/r/111024/#review115298

web-platform-tests has finally been synced so I think this is ok to land.

Comment 5

[Brian Birtles (:birtles)]

Mantaroh, are you going to land this?

Comment 6

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8835333 [details]
Bug 1338069 - Don't use 'window' object when using getComputedStyle in tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111024/diff/1-2/

Comment 7

[Mantaroh Yoshinaga[:mantaroh]]

(In reply to Brian Birtles (:birtles) from comment #5)
> Mantaroh, are you going to land this?

Sorry, I forgot to land it.

Try :
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eba443758b0896ec2f0f79c7058cfbb287a545cc

Comment 8

[Hiroyuki Ikezoe (:hiro)]

You can specify "--artifact" syntax for test file only changes.  It does not work on stylo for now though.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c80974470261
Don't use 'window' object when using getComputedStyle in tests. r=birtles

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c80974470261