1338073 - Editing comments in the drop-down editor doesn't update comments in the diff; text loss possible

Status: RESOLVED INVALID

(MozReview Graveyard :: Review Board: User Interface, defect, P1)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

STR:
1. Start a review
2. Add an issue in the diff (Press [+] on a line, type something, press OK).
The green "You have a pending review" bar should appear.
3. Click "Edit Review".
All comments should be shown in the further drop-down sub-window.
4. Click on the issue text, to start editing it.
5. Edit the text of the issue.
6. Press OK.
7. (Optional) Click "Finished edit" to hide the sub-window.

Expected:
In the diff view, the issue has been updated to the new text.

Actual:
The old text is still visible there. Clicking on it also shows the old text.


Marking as "major", because if you now edit that issue in the diff viewer, it will silently overwrite whatever you've done at step 5 above!

Comment 1

[Piotr Zalewa [:zalun]]

Attachment: issue explained in video

Comment 2

[Piotr Zalewa [:zalun]]

I think this should to be fixed upstream.
I've created a ticket.
https://hellosplat.com/s/beanbag/tickets/4529/

Comment 3

[BMO Automation]

MozReview is now obsolete. Please use Phabricator instead. Closing this bug.