1338075 - Cleanup browser/extensions/formautofill/.eslintrc.js

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement)

Description

[Matthew N. [:MattN]]

There are some redundant rules and cases where we are now less strict than the rest of browser/

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1338075 - formautofill: Remove eslint rules that match inheritted values.

Review commit: https://reviewboard.mozilla.org/r/111028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111028/

Comment 2

[Matthew N. [:MattN]]

Attachment: Bug 1338075 - formautofill: Remove eslint rules that match or are less strict than inheritted ones.

Review commit: https://reviewboard.mozilla.org/r/111030/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111030/

Comment 3

[Matthew N. [:MattN]]

Attachment: Bug 1338075 - formautofill: Enable object-shorthand.

Review commit: https://reviewboard.mozilla.org/r/111032/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111032/

Comment 4

[Matthew N. [:MattN]]

Attachment: Bug 1338075 - formautofill: Inherit all eslint rules where off is currently specified.

Review commit: https://reviewboard.mozilla.org/r/111034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111034/

Comment 5

[Matthew N. [:MattN]]

Attachment: Bug 1338075 - formautofill: Enable no-cpows-in-tests and var-only-at-top-level.

Review commit: https://reviewboard.mozilla.org/r/111036/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111036/

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8835357 [details]
Bug 1338075 - formautofill: Inherit all eslint rules where off is currently specified.

https://reviewboard.mozilla.org/r/111034/#review112700

::: browser/extensions/formautofill/.eslintrc.js:125
(Diff revision 1)
> -    // Don't enforce the maximum depth that blocks can be nested. The complexity
> -    // rule is a better rule to check this.
> -    "max-depth": "off",
> -
>      // Maximum length of a line.
>      // Disabled because we exceed this in too many places.

We might need to update the comment here.

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8835354 [details]
Bug 1338075 - formautofill: Remove eslint rules that match inheritted values.

https://reviewboard.mozilla.org/r/111028/#review112702

Comment 8

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8835355 [details]
Bug 1338075 - formautofill: Remove eslint rules that match or are less strict than inheritted ones.

https://reviewboard.mozilla.org/r/111030/#review112704

Comment 9

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8835356 [details]
Bug 1338075 - formautofill: Enable object-shorthand.

https://reviewboard.mozilla.org/r/111032/#review112708

Comment 10

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8835358 [details]
Bug 1338075 - formautofill: Enable no-cpows-in-tests and var-only-at-top-level.

https://reviewboard.mozilla.org/r/111036/#review112710

Comment 11

[Luke Chang [:lchang] (inactive)]

Looks good overall. Thanks for the cleanup.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/24793c847f3a
formautofill: Remove eslint rules that match inheritted values. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5370de77111
formautofill: Remove eslint rules that match or are less strict than inheritted ones. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/a45136b62bc5
formautofill: Enable object-shorthand. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/975aeeab6507
formautofill: Inherit all eslint rules where off is currently specified. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7d9562088cf
formautofill: Enable no-cpows-in-tests and var-only-at-top-level. r=lchang

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/24793c847f3a
https://hg.mozilla.org/mozilla-central/rev/a5370de77111
https://hg.mozilla.org/mozilla-central/rev/a45136b62bc5
https://hg.mozilla.org/mozilla-central/rev/975aeeab6507
https://hg.mozilla.org/mozilla-central/rev/f7d9562088cf