Cleanup browser/extensions/formautofill/.eslintrc.js

RESOLVED FIXED in Firefox 54

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: MattN, Assigned: MattN)

Tracking

unspecified
mozilla54
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox54 fixed)

Details

(Whiteboard: [form autofill:M1])

Attachments

(5 attachments)

There are some redundant rules and cases where we are now less strict than the rest of browser/
Comment hidden (mozreview-request)

Comment 6

2 years ago
mozreview-review
Comment on attachment 8835357 [details]
Bug 1338075 - formautofill: Inherit all eslint rules where off is currently specified.

https://reviewboard.mozilla.org/r/111034/#review112700

::: browser/extensions/formautofill/.eslintrc.js:125
(Diff revision 1)
> -    // Don't enforce the maximum depth that blocks can be nested. The complexity
> -    // rule is a better rule to check this.
> -    "max-depth": "off",
> -
>      // Maximum length of a line.
>      // Disabled because we exceed this in too many places.

We might need to update the comment here.
Attachment #8835357 - Flags: review?(lchang) → review+

Comment 7

2 years ago
mozreview-review
Comment on attachment 8835354 [details]
Bug 1338075 - formautofill: Remove eslint rules that match inheritted values.

https://reviewboard.mozilla.org/r/111028/#review112702
Attachment #8835354 - Flags: review?(lchang) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8835355 [details]
Bug 1338075 - formautofill: Remove eslint rules that match or are less strict than inheritted ones.

https://reviewboard.mozilla.org/r/111030/#review112704
Attachment #8835355 - Flags: review?(lchang) → review+

Comment 9

2 years ago
mozreview-review
Comment on attachment 8835356 [details]
Bug 1338075 - formautofill: Enable object-shorthand.

https://reviewboard.mozilla.org/r/111032/#review112708
Attachment #8835356 - Flags: review?(lchang) → review+

Comment 10

2 years ago
mozreview-review
Comment on attachment 8835358 [details]
Bug 1338075 - formautofill: Enable no-cpows-in-tests and var-only-at-top-level.

https://reviewboard.mozilla.org/r/111036/#review112710
Attachment #8835358 - Flags: review?(lchang) → review+
Looks good overall. Thanks for the cleanup.

Comment 12

2 years ago
Pushed by mozilla@noorenberghe.ca:
https://hg.mozilla.org/integration/mozilla-inbound/rev/24793c847f3a
formautofill: Remove eslint rules that match inheritted values. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/a5370de77111
formautofill: Remove eslint rules that match or are less strict than inheritted ones. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/a45136b62bc5
formautofill: Enable object-shorthand. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/975aeeab6507
formautofill: Inherit all eslint rules where off is currently specified. r=lchang
https://hg.mozilla.org/integration/mozilla-inbound/rev/f7d9562088cf
formautofill: Enable no-cpows-in-tests and var-only-at-top-level. r=lchang
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.