Unnecessary change of visit date format in Library. The change makes user confusing.

VERIFIED FIXED in Firefox 52

Status

()

Firefox
Bookmarks & History
P1
normal
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: Alice0775 White, Assigned: mak)

Tracking

({regression, ux-consistency})

52 Branch
Firefox 54
regression, ux-consistency
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox51 unaffected, firefox52+ verified, firefox53+ verified, firefox54+ verified, firefox-esr45 unaffected, firefox-esr52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

3 months ago
Created attachment 8835366 [details]
Screenshot en-US

[Tracking Requested - why for this release]: Unnecessary change of visit date format in Library.  The change makes user confusing.

Steps To Reproduce:
1. Open Show All History
2. Add Most Recent Visit

Actual Results:
Visit date format in Library is changed since beta52

Expected Results:
Do not perform unnecessary changes in appearance confusing users.
Visit date format in Library  should be same results between Firefox51.0.1 and Beta52.0b4


Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=d523f32cf87f2122fbbca86e0e3d2d0a26942ab6&tochange=686282bd2f19b5f0ab249cde34caea04fc5c17a1

Regressed by: Bug 1301655
(Reporter)

Comment 1

3 months ago
Created attachment 8835367 [details]
Screenshot ja
(Assignee)

Updated

3 months ago
Flags: needinfo?(jfkthame)
(Assignee)

Comment 2

3 months ago
The regression is likely in https://hg.mozilla.org/mozilla-central/rev/68543a46ef49
Likely in _dateFormatter, year: '2-digit' should surely be changed to full year, and uplifted.
The rest is opinable, looks like we were using a sort-of ISO 8601 date, but with slashes. I'd suggest to be consistent with the most common UI our users may be used to see, that is Windows Explorer.
(Assignee)

Comment 3

3 months ago
[Tracking Requested - why for this release]:
tracking-firefox53: --- → ?
tracking-firefox54: --- → ?
(Assignee)

Updated

3 months ago
Priority: -- → P1
(Assignee)

Updated

3 months ago
Component: Places → Bookmarks & History
Product: Toolkit → Firefox
(Assignee)

Comment 4

3 months ago
I was looking at various Explorer sshots around.
Looks like in ja we want YYYY/MM/DD HH:MM while in en-us MM/DD/YYYY HH:MM AM

Based on the screenshots, the only thing we should change is the 4digits year.
(Assignee)

Comment 5

3 months ago
I'll just attach a patch.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Flags: needinfo?(jfkthame)
Yes, it should be a 4-digit year. (Apparently that's what we were getting from Ci.nsIScriptableDateFormat.dateFormatShort despite the "short" part of its name...)

Thanks for taking care of this, Marco.
Comment hidden (mozreview-request)

Comment 8

3 months ago
mozreview-review
Comment on attachment 8835381 [details]
Bug 1338083 - Restore full year in Library date columns.

https://reviewboard.mozilla.org/r/111070/#review112330
Attachment #8835381 - Flags: review?(jfkthame) → review+

Comment 9

3 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/6db943216f7e
Restore full year in Library date columns. r=jfkthame
Tracking for all branches. Once this is fixed, please request uplift if you want this patch on 52 before we ship.

Thanks Alice for filing the bug and mak for fixing it.
tracking-firefox52: ? → +
tracking-firefox53: ? → +
tracking-firefox54: ? → +

Comment 11

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/6db943216f7e
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
(Assignee)

Comment 12

3 months ago
Comment on attachment 8835381 [details]
Bug 1338083 - Restore full year in Library date columns.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1301655
[User impact if declined]: Dates in the Library are hard to read and may confuse users
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: not yet, nightly will be available in a few hours.
[Needs manual test from QE? If yes, steps to reproduce]: yes, it's trivial to verify by just looking at the Library, showing a date column and checking the year is full 4 digit
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: just changing year format from 2-digit to full year
[String changes made/needed]: none
Attachment #8835381 - Flags: approval-mozilla-beta?
Attachment #8835381 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 13

3 months ago
Verified Fixed in Nightly 20170210030206
Status: RESOLVED → VERIFIED
status-firefox54: fixed → verified
Comment on attachment 8835381 [details]
Bug 1338083 - Restore full year in Library date columns.

revert recent unintentional UI change in aurora53, beta52
Attachment #8835381 - Flags: approval-mozilla-beta?
Attachment #8835381 - Flags: approval-mozilla-beta+
Attachment #8835381 - Flags: approval-mozilla-aurora?
Attachment #8835381 - Flags: approval-mozilla-aurora+

Comment 15

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/e26d8e25df97
status-firefox53: affected → fixed
Flags: in-testsuite+

Comment 16

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/a02c7784fc53
status-firefox52: affected → fixed
Flags: qe-verify+
QA Contact: timea.zsoldos

Comment 17

2 months ago
I have reproduced this issue using Firefox 52.0b4 (20170206101855) on Win 8.1 x64.
I can confirm this issue is fixed, I verified using Firefox 52.0b6 and 53.0a2 on Win 8.1 x64, Ubuntu 16.04 x64 and Mac OS X 10.11.
status-firefox52: fixed → verified
status-firefox53: fixed → verified
Flags: in-testsuite+
QA Contact: timea.zsoldos

Updated

2 months ago
Flags: qe-verify+

Comment 18

2 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-esr52/rev/a02c7784fc53
status-firefox-esr52: --- → fixed
Flags: in-testsuite+
You need to log in before you can comment on or make changes to this bug.