1338096 - [e10s] Http Channel Priority doesn't pass the correct numeric value over IPDL

Status: RESOLVED FIXED

(Core :: Networking: HTTP, defect)

Description

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The value of priority is stored in `int16_t`. In PHttpChannel.ipdl and NeckoChannelParams.ipdlh we use `uint16_t` as the data type to pass it over IPC. However the value is used as a parameter of `int32_t` directly, which cause all the negative value being converted to some value larger than 32768.

The solution is to use int16_t in IPDL instead of uint16_t.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Attachment: Bug 1338096 - correct the data type used in PHttpChannel.SetPriority().

Review commit: https://reviewboard.mozilla.org/r/111186/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111186/

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 8835442 [details]
Bug 1338096 - correct the data type used in PHttpChannel.SetPriority().

https://reviewboard.mozilla.org/r/111186/#review112482

thanks, good catch!

::: netwerk/protocol/http/HttpChannelParent.cpp:628
(Diff revision 1)
>  }
>  
>  mozilla::ipc::IPCResult
> -HttpChannelParent::RecvSetPriority(const uint16_t& priority)
> +HttpChannelParent::RecvSetPriority(const int16_t& priority)
>  {
>    LOG(("HttpChannelParent::RecvSetPriority [this=%p, priority=%u]\n",

priority=%d in the log

Comment 3

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8835442 [details]
Bug 1338096 - correct the data type used in PHttpChannel.SetPriority().

https://reviewboard.mozilla.org/r/111186/#review112482

> priority=%d in the log

fixed in next revision

Comment 4

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Comment on attachment 8835442 [details]
Bug 1338096 - correct the data type used in PHttpChannel.SetPriority().

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/111186/diff/1-2/

Comment 5

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

Test case is provided along with bug 1337721.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae2a6bd17689
correct the data type used in PHttpChannel.SetPriority(). r=mayhemer

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae2a6bd17689