1338103 - SETA: confusing methods/variables with same names

Status: RESOLVED FIXED

(Tree Management Graveyard :: Treeherder: SETA, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

while searching for ref_data_names, I ended up seeing method definitions and variable declarations- I would prefer to fix this at least in the seta specific code to not be confusing (or possibly leaking in errors).

I am specifically concerned with these two files:
https://github.com/mozilla/treeherder/blob/f6ac262dd07b8cac14c5fe38c1f3bd6c642e5af7/treeherder/etl/seta.py
https://github.com/mozilla/treeherder/blob/f6ac262dd07b8cac14c5fe38c1f3bd6c642e5af7/treeherder/seta/job_priorities.py

essentially we are collecting the ref_data_name value from runnable jobs and building a key/value mapping.

so for the function, we should rename it to:
build_ref_data_names_map()

and for the internal variables both to the function and used elsewhere in job_priorities, possibly leave them alone?

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] rwood-moz:bug1338103 > mozilla:master

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8836077 [details] [review]
[treeherder] rwood-moz:bug1338103 > mozilla:master

that was easier than I thought

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/2b7b0e62f27826324add96743b03247fc1b952c9
Bug 1338103 - Rename SETA function so it doesn't match local vars (#2157)