Closed Bug 1338126 Opened 5 years ago Closed 5 years ago

Rename compound HasProperty+GetProperty from GetElement to HasAndGetElement in jsarray.cpp

Categories

(Core :: JavaScript Engine, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(1 file)

Suggested by :evilpie in bug 1323825, comment #4.
Attached patch bug1338126.patchSplinter Review
Simply renames the method from GetElement to HasAndGetElement.
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Attachment #8856452 - Flags: review?(evilpies)
Comment on attachment 8856452 [details] [diff] [review]
bug1338126.patch

Review of attachment 8856452 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for changing this. I think we have enough GetElement variants that renaming the one that does something else is a good idea.
Attachment #8856452 - Flags: review?(evilpies) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca66824761a9
Rename compound HasProperty+GetProperty from GetElement to HasAndGetElement. r=evilpie
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ca66824761a9
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.