Closed
Bug 1338168
Opened 7 years ago
Closed 7 years ago
micro-optimize GetListenerInfoFor
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
smaug
:
review+
baku
:
review+
|
Details | Diff | Splinter Review |
We can use nsCOMArray::Forget() to avoid some unnecessary refcounting.
|
Assignee | |
Comment 1•7 years ago
|
||
This is really only called by devtools, but maybe being a little bit faster there is nice?
Attachment #8835534 -
Flags: review?(amarchesini)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8835534 [details] [diff] [review] micro-optimize GetListenerInfoFor Review of attachment 8835534 [details] [diff] [review]: ----------------------------------------------------------------- I'm not an dom/event peer.
Attachment #8835534 -
Flags: review?(bugs)
Attachment #8835534 -
Flags: review?(amarchesini)
Attachment #8835534 -
Flags: review+
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8835534 [details] [diff] [review] micro-optimize GetListenerInfoFor Ah, interesting, nsCOMArray::Forget does still an allocation.
Attachment #8835534 -
Flags: review?(bugs) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3cac14211742 micro-optimize GetListenerInfoFor; r=baku,smaug
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3cac14211742
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•