Remove support for windowed-mode plugins on Linux

RESOLVED FIXED in Firefox 54

Status

()

Core
Plug-ins
P2
normal
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: bsmedberg, Assigned: bsmedberg)

Tracking

(Blocks: 1 bug)

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

(Assignee)

Description

6 months ago
This is a subset of bug 1296400, filed separately because we can do this on Linux now but not on Windows yet. Remove the goop that supports windowed-mode plugins on Linux. This will include all support for old xt-style plugins.
(Assignee)

Updated

6 months ago
Assignee: nobody → benjamin
Status: NEW → ASSIGNED
Priority: -- → P2
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 6

6 months ago
mozreview-review
Comment on attachment 8836189 [details]
Bug 1338172 part A - remove windowed plugin support from the GTK testplugin,

https://reviewboard.mozilla.org/r/111628/#review113698
Attachment #8836189 - Flags: review?(jmathies) → review+

Comment 7

6 months ago
mozreview-review
Comment on attachment 8836190 [details]
Bug 1338172 part B - remove the ancient carbon detection on Mac which is no longer used,

https://reviewboard.mozilla.org/r/111630/#review113700
Attachment #8836190 - Flags: review?(jmathies) → review+

Comment 8

6 months ago
mozreview-review
Comment on attachment 8836191 [details]
Bug 1338172 part C - Remove support for windowed mode plugins on Linux (GTK).

https://reviewboard.mozilla.org/r/111632/#review113702
Attachment #8836191 - Flags: review?(jmathies) → review+

Comment 9

6 months ago
mozreview-review
Comment on attachment 8836193 [details]
Bug 1338172 part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere,

https://reviewboard.mozilla.org/r/111636/#review113710
Attachment #8836193 - Flags: review?(jmathies) → review+

Comment 10

6 months ago
mozreview-review
Comment on attachment 8836192 [details]
Bug 1338172 part D - Fix tests that expect windowed mode on Linux,

https://reviewboard.mozilla.org/r/111634/#review113712
Attachment #8836192 - Flags: review?(jmathies) → review+

Comment 11

6 months ago
Pushed by bsmedberg@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6209f07e1f26
part A - remove windowed plugin support from the GTK testplugin, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4994ab9d628
part B - remove the ancient carbon detection on Mac which is no longer used, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/907d9c3d1043
part C - Remove support for windowed mode plugins on Linux (GTK). r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c92fbfca20a
part D - Fix tests that expect windowed mode on Linux, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ee6c6f4e59c
part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm
I had to back these out for linux crashtest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=77334859&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/12a0181ef7db
Flags: needinfo?(benjamin)
(Assignee)

Comment 13

6 months ago
These failures are being dealth with in bug 1342141.
Depends on: 1342141
Flags: needinfo?(benjamin)

Comment 14

6 months ago
Pushed by bsmedberg@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21643634694e
part A - remove windowed plugin support from the GTK testplugin, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/d209d88c5e20
part B - remove the ancient carbon detection on Mac which is no longer used, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/74cabd7a09b6
part C - Remove support for windowed mode plugins on Linux (GTK). r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/df468e6fe766
part D - Fix tests that expect windowed mode on Linux, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a7996fa2e1b
part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm

Comment 15

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/21643634694e
https://hg.mozilla.org/mozilla-central/rev/d209d88c5e20
https://hg.mozilla.org/mozilla-central/rev/74cabd7a09b6
https://hg.mozilla.org/mozilla-central/rev/df468e6fe766
https://hg.mozilla.org/mozilla-central/rev/6a7996fa2e1b
Status: ASSIGNED → RESOLVED
Last Resolved: 6 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
Benjamin, would this feature/change benefit from manual testing? If that is the case, could you please expand on what our main focus should be for windowless plug-ins?

Short term, this bug would be a priority for Release QA, as it's already in Beta, but I think we should set expectations for Bug 1296400 as a whole.
Flags: needinfo?(benjamin)
(Assignee)

Comment 17

4 months ago
Andrei, the user-visible change here is in bug 1337781, and I believe that Stefan did a brief QA pass on that when it landed. I know we discussed it and because it's Linux it was fairly low-priority spot checking, not a full testing pass.
Flags: needinfo?(benjamin)
You need to log in before you can comment on or make changes to this bug.