1338172 - Remove support for windowed-mode plugins on Linux

Status: RESOLVED FIXED

(Core :: Plug-ins, defect, P2)

Description

[Benjamin Smedberg]

This is a subset of bug 1296400, filed separately because we can do this on Linux now but not on Windows yet. Remove the goop that supports windowed-mode plugins on Linux. This will include all support for old xt-style plugins.

Comment 1

[Benjamin Smedberg]

Attachment: Bug 1338172 part A - remove windowed plugin support from the GTK testplugin,

Review commit: https://reviewboard.mozilla.org/r/111628/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111628/

Comment 2

[Benjamin Smedberg]

Attachment: Bug 1338172 part B - remove the ancient carbon detection on Mac which is no longer used,

Review commit: https://reviewboard.mozilla.org/r/111630/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111630/

Comment 3

[Benjamin Smedberg]

Attachment: Bug 1338172 part C - Remove support for windowed mode plugins on Linux (GTK).

Review commit: https://reviewboard.mozilla.org/r/111632/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111632/

Comment 4

[Benjamin Smedberg]

Attachment: Bug 1338172 part D - Fix tests that expect windowed mode on Linux,

Review commit: https://reviewboard.mozilla.org/r/111634/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111634/

Comment 5

[Benjamin Smedberg]

Attachment: Bug 1338172 part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere,

Review commit: https://reviewboard.mozilla.org/r/111636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111636/

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 8836189 [details]
Bug 1338172 part A - remove windowed plugin support from the GTK testplugin,

https://reviewboard.mozilla.org/r/111628/#review113698

Comment 7

[Jim Mathies [:jimm]]

Comment on attachment 8836190 [details]
Bug 1338172 part B - remove the ancient carbon detection on Mac which is no longer used,

https://reviewboard.mozilla.org/r/111630/#review113700

Comment 8

[Jim Mathies [:jimm]]

Comment on attachment 8836191 [details]
Bug 1338172 part C - Remove support for windowed mode plugins on Linux (GTK).

https://reviewboard.mozilla.org/r/111632/#review113702

Comment 9

[Jim Mathies [:jimm]]

Comment on attachment 8836193 [details]
Bug 1338172 part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere,

https://reviewboard.mozilla.org/r/111636/#review113710

Comment 10

[Jim Mathies [:jimm]]

Comment on attachment 8836192 [details]
Bug 1338172 part D - Fix tests that expect windowed mode on Linux,

https://reviewboard.mozilla.org/r/111634/#review113712

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6209f07e1f26
part A - remove windowed plugin support from the GTK testplugin, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4994ab9d628
part B - remove the ancient carbon detection on Mac which is no longer used, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/907d9c3d1043
part C - Remove support for windowed mode plugins on Linux (GTK). r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c92fbfca20a
part D - Fix tests that expect windowed mode on Linux, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ee6c6f4e59c
part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back these out for linux crashtest failures like https://treeherder.mozilla.org/logviewer.html#?job_id=77334859&repo=mozilla-inbound

https://hg.mozilla.org/integration/mozilla-inbound/rev/12a0181ef7db

Comment 13

[Benjamin Smedberg]

These failures are being dealth with in bug 1342141.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/21643634694e
part A - remove windowed plugin support from the GTK testplugin, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/d209d88c5e20
part B - remove the ancient carbon detection on Mac which is no longer used, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/74cabd7a09b6
part C - Remove support for windowed mode plugins on Linux (GTK). r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/df468e6fe766
part D - Fix tests that expect windowed mode on Linux, r=jimm
https://hg.mozilla.org/integration/mozilla-inbound/rev/6a7996fa2e1b
part E - make all the PPluginWidget stuff Windows-only. Rip out the GTK-specific native widget support from widget/gtk/nsWindow and elsewhere, r=jimm

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/21643634694e
https://hg.mozilla.org/mozilla-central/rev/d209d88c5e20
https://hg.mozilla.org/mozilla-central/rev/74cabd7a09b6
https://hg.mozilla.org/mozilla-central/rev/df468e6fe766
https://hg.mozilla.org/mozilla-central/rev/6a7996fa2e1b

Comment 16

[Andrei Vaida [:avaida]]

Benjamin, would this feature/change benefit from manual testing? If that is the case, could you please expand on what our main focus should be for windowless plug-ins?

Short term, this bug would be a priority for Release QA, as it's already in Beta, but I think we should set expectations for Bug 1296400 as a whole.

Comment 17

[Benjamin Smedberg]

Andrei, the user-visible change here is in bug 1337781, and I believe that Stefan did a brief QA pass on that when it landed. I know we discussed it and because it's Linux it was fairly low-priority spot checking, not a full testing pass.