remove service-workers/service-worker/resources/get-host-info.sub.js

RESOLVED FIXED in Firefox 54

Status

defect
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

Version 3
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

Service worker tests currently use a custom get-host-info.sub.js file instead of /common/get-host-info.sub.js.  We should make these tests just use the common one.
This removes the service-workers/service-worker version of get-host-info.sub.js in favor of the /common/ version.  Note that the SW file did have UNAUTHENTICATED_ORIGIN, but that doesn't seem to be used anywhere.

Basically the SW get-host-info.sub.js is not maintained as well as the common one.  We should remove this duplication.

Passes SW tests locally, but lets verify on try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2269f184390b4fa516b04d7a607b767f4cf99463
Attachment #8835555 - Flags: review?(james)
Attachment #8835555 - Flags: review?(james) → review+

Comment 2

2 years ago
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8eec8c332e
Remove the service-worker version of get-host-info.sub.js. r=jgraham

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0a8eec8c332e
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.