Closed
Bug 1338173
Opened 8 years ago
Closed 8 years ago
remove service-workers/service-worker/resources/get-host-info.sub.js
Categories
(Testing :: web-platform-tests, defect)
Tracking
(firefox54 fixed)
RESOLVED
FIXED
mozilla54
| Tracking | Status | |
|---|---|---|
| firefox54 | --- | fixed |
People
(Reporter: bkelly, Assigned: bkelly)
References
Details
Attachments
(1 file)
|
70.62 KB,
patch
|
jgraham
:
review+
|
Details | Diff | Splinter Review |
Service worker tests currently use a custom get-host-info.sub.js file instead of /common/get-host-info.sub.js. We should make these tests just use the common one.
|
Assignee | |
Comment 1•8 years ago
|
||
This removes the service-workers/service-worker version of get-host-info.sub.js in favor of the /common/ version. Note that the SW file did have UNAUTHENTICATED_ORIGIN, but that doesn't seem to be used anywhere.
Basically the SW get-host-info.sub.js is not maintained as well as the common one. We should remove this duplication.
Passes SW tests locally, but lets verify on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2269f184390b4fa516b04d7a607b767f4cf99463
Attachment #8835555 -
Flags: review?(james)
|
||
Updated•8 years ago
|
Attachment #8835555 -
Flags: review?(james) → review+
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8eec8c332e
Remove the service-worker version of get-host-info.sub.js. r=jgraham
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•