1338190 - [skiplist] Add CrashReporter::TerminateHandler to skip list

Status: RESOLVED FIXED

(Socorro :: Signature, task, P2)

Description

[Mike Conley (:mconley) (:⚙️)]

CrashReporter::TerminateHandler is the generic uncaught exception handler that I added in bug 1333223. CrashReporter::TerminateHandler in the signatures is not useful, as it really just calls MOZ_CRASH when we hit it so that we create a crash report. We should add that to the skip list.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Tossing this in the queue of things to do.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

Bumping this bug to the signature component.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

Here are two recent example crashes:

65f06168-fb40-4ed9-9346-ae7720180109
441d474a-7cfb-4f30-856c-65a9f0180108


Adding CrashReporter::TerminateHandler yields this:

app@processor:/app$ python -m socorro.signature 65f06168-fb40-4ed9-9346-ae7720180109 441d474a-7cfb-4f30-856c-65a9f0180108
Crash id: 65f06168-fb40-4ed9-9346-ae7720180109
Original: CrashReporter::TerminateHandler
New:      CrashReporter::TerminateHandler | std::__terminate
Same?:    False

Crash id: 441d474a-7cfb-4f30-856c-65a9f0180108
Original: CrashReporter::TerminateHandler
New:      CrashReporter::TerminateHandler | libc++abi.dylib@0x23d68
Same?:    False

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Grabbing this.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla-services/socorro

https://github.com/mozilla-services/socorro/commit/dce65e4ee2ec4465f15dbe29721b228f176c5780
fixes bug 1338190 - add CrashReporter::TerminateHandler to prefix list

https://github.com/mozilla-services/socorro/commit/e63d5a1dd9a3d7c46d9d2c97157877f5ab25076f
Merge pull request #4281 from willkg/1338190-terminatehandler

fixes bug 1338190 - add CrashReporter::TerminateHandler to prefix list