If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

select dropdowns with custom styling applied directly to the <select> on Linux do not display the styling

RESOLVED FIXED in Firefox 54

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

This is because it the xul:menupopup needs -moz-appearance:none;
Comment hidden (mozreview-request)
This patch also fixes the hover styling for these custom styled options. Note that I couldn't get -moz-menuhover and -moz-menuhovertext to apply while -moz-appearance was set to none. However highlight and highlighttext do apply and look reasonably similar to -moz-menuhover*, just missing the gradient.

The CSS properties are defined with color first, then background-color to maintain consistency with the rules a few line above (otherwise I probably would have put them in alphabetical order).
Comment on attachment 8835599 [details]
Bug 1338219 - Disable platform appearance for custom styled popups on Linux to allow for custom colors to be used.

https://reviewboard.mozilla.org/r/111284/#review112516

Looks okay to me, but I didn't test.

I wonder if it'd be useful to add a mozscreenshots configuration for styled and unstyled select dropdowns.
Attachment #8835599 - Flags: review?(mconley) → review+
Yeah, I like the idea of using mozscreenshots more. Let's set up a time to talk with MattN about the limits that it currently has and what needs to be done to get it in higher use (how to mark builds as "good" or "bad", getting it run on test machines that have the same desktop background each time [or maximized], how to add test cases without exponentially increasing the test run, etc). 

I'll send an email to you and MattN now.

Comment 5

8 months ago
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/44281228fbff
Disable platform appearance for custom styled popups on Linux to allow for custom colors to be used. r=mconley

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/44281228fbff
Status: ASSIGNED → RESOLVED
Last Resolved: 8 months ago
status-firefox54: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54

Comment 7

8 months ago
The problem I had reported in bug 1336301, now transferred to this bug, is not present this morning.
FF:   	20170210110240
Operating system:  	Linux 4.4.0-62-generic
Useragent:  	Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0

Previous to this, a comment was made that an earlier version of the fix corrected the issue on Windows 10.  
If the fix has different paths based on platform, has it been verified on other versions such as Apple?

Thanks for getting it fixed quickly.
The previous patch was verified on Windows and OSX, but hadn't been verified on Linux. The patch on this bug fixes the issue on Linux and it doesn't affect any code for other platforms.

You're welcome, thank you for letting me know so quickly.
(Assignee)

Updated

8 months ago
Blocks: 910022
Depends on: 1339769

Comment 9

7 months ago
This issue may break http://www.samcodes.co.uk/project/game-of-life/, not sure if https://bugzilla.mozilla.org/show_bug.cgi?id=1338850 could fix this?
(In reply to Eric Tsai from comment #9)
> This issue may break http://www.samcodes.co.uk/project/game-of-life/, not
> sure if https://bugzilla.mozilla.org/show_bug.cgi?id=1338850 could fix this?

Yeah, that issue is fixed by bug 1338850.
You need to log in before you can comment on or make changes to this bug.