Closed Bug 1338253 Opened 7 years ago Closed 7 years ago

Remove legacy generator from extensions/cookie/.

Categories

(Core :: Networking: Cookies, defect)

Product:
Core
Component:
Networking: Cookies
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla54
Tracking Flags:
Tracking Status
firefox54 --- fixed

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file, 1 obsolete file)

Remove remaining legacy generator from extensions/cookie/test/.
22.35 KB, patch
jdm
: review+
Details | Diff | Splinter Review 
      No description provided.
just changed legacy generator to ES6 generator.

I was about to rewrite all of them with async function, but it looks like some testcases critically depend on timing, and introducing promise breaks it.
Attachment #8835786 - Flags: review?(josh)
sorry, I accidentally included a file for another bug.
removed the change for extensions/spellcheck/hunspell/tests/unit/test_hunspell.js
no other change.
Attachment #8835786 - Attachment is obsolete: true
Attachment #8835786 - Flags: review?(josh)
Attachment #8835992 - Flags: review?(josh)
Attachment #8835992 - Flags: review?(josh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e5556a5aab7604767c930233e58b6fa98a7a770
Bug 1338253 - Remove remaining legacy generator from extensions/cookie/test/. r=jdm
https://hg.mozilla.org/mozilla-central/rev/5e5556a5aab7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: