Closed
Bug 1338264
Opened 8 years ago
Closed 8 years ago
Double closing parenthesis in gdata-event-dialog-reminder.js
Categories
(Calendar :: Provider: GData, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
5.5
People
(Reporter: MakeMyDay, Assigned: MakeMyDay)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.15 KB,
patch
|
Fallen
:
review+
Fallen
:
approval-calendar-aurora+
|
Details | Diff | Splinter Review |
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8835633 -
Flags: review?(philipp)
Attachment #8835633 -
Flags: approval-calendar-aurora?(philipp)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8835633 [details] [diff] [review]
FixGdataEventDialogReminder-V1.diff
Review of attachment 8835633 [details] [diff] [review]:
-----------------------------------------------------------------
Oh wow, good catch. Surprised this wasn't caught earlier.
Attachment #8835633 -
Flags: review?(philipp)
Attachment #8835633 -
Flags: review+
Attachment #8835633 -
Flags: approval-calendar-aurora?(philipp)
Attachment #8835633 -
Flags: approval-calendar-aurora+
|
|
||
Comment 3•8 years ago
|
||
Maybe this should be landed after the shims bug, it would be easier to unbitrot this patch.
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
|
||
Comment 4•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.6
|
|
||
Comment 5•8 years ago
|
||
Aurora (TB 53, Calendar 5.5):
https://hg.mozilla.org/releases/comm-aurora/rev/d8bf1b72deffab44dd71a6e9d145c6d6ae0b4c96
Target Milestone: 5.6 → 5.5
You need to log in
before you can comment on or make changes to this bug.
Description
•