Closed Bug 1338264 Opened 3 years ago Closed 3 years ago

Double closing parenthesis in gdata-event-dialog-reminder.js

Categories

(Calendar :: Provider: GData, defect)

Lightning 5.5
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

References

Details

(Keywords: regression)

Attachments

(1 file)

Attachment #8835633 - Flags: review?(philipp)
Attachment #8835633 - Flags: approval-calendar-aurora?(philipp)
Comment on attachment 8835633 [details] [diff] [review]
FixGdataEventDialogReminder-V1.diff

Review of attachment 8835633 [details] [diff] [review]:
-----------------------------------------------------------------

Oh wow, good catch. Surprised this wasn't caught earlier.
Attachment #8835633 - Flags: review?(philipp)
Attachment #8835633 - Flags: review+
Attachment #8835633 - Flags: approval-calendar-aurora?(philipp)
Attachment #8835633 - Flags: approval-calendar-aurora+
Maybe this should be landed after the shims bug, it would be easier to unbitrot this patch.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/f76125523411a56c3bd1635cd763beadb30840e8
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 5.6
Aurora (TB 53, Calendar 5.5):
https://hg.mozilla.org/releases/comm-aurora/rev/d8bf1b72deffab44dd71a6e9d145c6d6ae0b4c96
Target Milestone: 5.6 → 5.5
You need to log in before you can comment on or make changes to this bug.