Closed Bug 1338273 Opened 3 years ago Closed 3 years ago

Field "stats.stun_retransmits" is uninitialized

Categories

(Core :: WebRTC: Networking, defect, P1)

45 Branch
defect

Tracking

()

RESOLVED FIXED
mozilla54
Tracking Status
firefox54 --- fixed

People

(Reporter: jesup, Assigned: mjf)

References

Details

Attachments

(1 file)

________________________________________________________________________________________________________
*** CID 1399690:  Uninitialized variables  (UNINIT)
/media/mtransport/nricectxhandler.cpp: 183 in mozilla::NrIceCtxHandler::Destroy()()
177         stats = current_ctx->Destroy();
178       }
179     
180       old_ctx = nullptr;
181       current_ctx = nullptr;
182     
>>>     CID 1399690:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "stats". Field "stats.stun_retransmits" is uninitialized.
183       return stats;
184     }
185     
186     NrIceCtxHandler::~NrIceCtxHandler()
187     {
188       Destroy();
189     }
190
Probably fallout from recent stats changes
Rank: 19
Priority: P2 → P1
It looks like mozilla::NrIceStats is always constructed then conditionally filled. It probably should be zeroed in the constructor.
This got added by Michael in bug 1325536 to allow reporting of ICE stats. Michael can you have a look at how to fix this?
Depends on: 1325536
Flags: needinfo?(mfroman)
Assignee: nobody → mfroman
Flags: needinfo?(mfroman)
Comment on attachment 8836812 [details]
Bug 1338273 - initialize NrIceStats vars to zero.

https://reviewboard.mozilla.org/r/112128/#review113476
Attachment #8836812 - Flags: review?(drno) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ae19cb15ab0c
initialize NrIceStats vars to zero. r=drno
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ae19cb15ab0c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.