1338273 - Field "stats.stun_retransmits" is uninitialized

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect, P1)

Description

[Randell Jesup [:jesup] (needinfo me)]

________________________________________________________________________________________________________
*** CID 1399690:  Uninitialized variables  (UNINIT)
/media/mtransport/nricectxhandler.cpp: 183 in mozilla::NrIceCtxHandler::Destroy()()
177         stats = current_ctx->Destroy();
178       }
179     
180       old_ctx = nullptr;
181       current_ctx = nullptr;
182     
>>>     CID 1399690:  Uninitialized variables  (UNINIT)
>>>     Using uninitialized value "stats". Field "stats.stun_retransmits" is uninitialized.
183       return stats;
184     }
185     
186     NrIceCtxHandler::~NrIceCtxHandler()
187     {
188       Destroy();
189     }
190

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Probably fallout from recent stats changes

Comment 2

[Nico Grunbaum [:ng, @chew:mozilla.org]]

It looks like mozilla::NrIceStats is always constructed then conditionally filled. It probably should be zeroed in the constructor.

Comment 3

[Nils Ohlmeier [:drno]]

This got added by Michael in bug 1325536 to allow reporting of ICE stats. Michael can you have a look at how to fix this?

Comment 4

[Michael Froman [:mjf]]

Attachment: Bug 1338273 - initialize NrIceStats vars to zero.

Review commit: https://reviewboard.mozilla.org/r/112128/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112128/

Comment 5

[Nils Ohlmeier [:drno]]

Comment on attachment 8836812 [details]
Bug 1338273 - initialize NrIceStats vars to zero.

https://reviewboard.mozilla.org/r/112128/#review113476

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae19cb15ab0c
initialize NrIceStats vars to zero. r=drno

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ae19cb15ab0c