1338286 - Send .extra from content process through CustomClientInfo rather than writing them to a temporary directory

Status: NEW

(Toolkit :: Crash Reporting, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1236108 added the capability for the content process to write .extra, which gets written to a temporary directory on content process crash, which the parent is responsible for picking up and packaging up with its own .extra when processing the crash report.

That works alright, but falls over if the parent crashes or shuts down before it can properly combine the .extra files. We should send the .extra information from the content process along with the minidump so that the parent either has it or doesn't, and we don't have this middle-state where its written to disk but not directly associated with a minidump.

Now that we're forking Breakpad[1], we can probably do this with less fuss than trying to upstream a patch.

[1]: https://groups.google.com/forum/#!topic/mozilla.dev.platform/WmjC4U-iMPI

Comment 1

[Mike Conley (:mconley) (:⚙️)]

According to aklotz, we'd want to implement CustomClientInfo for Linux and OS X, since right now it's only supported on Windows.

We might also want to shift away from that being a fixed-size Array, though I don't know how practical that is.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

You might want to take a look at what has been done with bug 1278717. I'm not sure if that solves this problem for us or not, but I know that we've needed to work around the child process .extra files in non-content child processes. There might have been something useful added that that would render this work unnecessary.