Closed
Bug 1338310
Opened 7 years ago
Closed 7 years ago
rm PCrashReporter
Categories
(Core :: IPC, defect)
Core
IPC
Tracking
()
RESOLVED
FIXED
mozilla54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file)
19.83 KB,
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
After bug 1338308, bug 1338281, and bug 1337518 there are no more uses of this class.
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8835689 -
Flags: review?(wmccloskey)
Comment on attachment 8835689 [details] [diff] [review] bug1338310.patch Review of attachment 8835689 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/crashreporter/nsExceptionHandler.cpp @@ +2292,1 @@ > if (!NS_IsMainThread()) { I think we should just release assert that we're on the main thread. The only reason we get here is that we didn't initialize the CrashReporterClient code early enough, and there shouldn't be any threads running at that point. I'd even be okay release asserting that the CrashReporterClient always exists when we write an annotation, but I'm not sure that would hold. @@ +2369,1 @@ > if (!NS_IsMainThread()) { Same here.
Attachment #8835689 -
Flags: review?(wmccloskey) → review+
Pushed by danderson@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9eec9caa5b5d Remove PCrashReporter. (bug 1338310, r=billm)
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9eec9caa5b5d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox54:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in
before you can comment on or make changes to this bug.
Description
•