Closed Bug 1338338 Opened 7 years ago Closed 7 years ago

[swift-3-regression] Crash when AuthenticationDialog is called 3 times in a row

Categories

(Firefox for iOS :: Build & Test, defect)

Other
iOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Iteration:
1.15

People

(Reporter: njpark, Assigned: fluffyemily)

References

Details

(Keywords: crash, reproducible, Whiteboard: [mobileCore])

Attachments

(1 file)

55 bytes, text/x-github-pull-request
sleroux
: review+
Details | Review
When executing UITests/Authenticationtests, as part of the test procedure, the username/password dialog is summoned 3 times in a row by entering incorrect username/password combination.  In swift 3, when the dialog pops up for the 3rd time, the app crashes with following error:

fatal error: Updated constraint could not find existing matching constraint to update: <SnapKit.LayoutConstraint:0x6000002bb480@BrowserViewController.swift#1920 Client.TimerSnackBar:0x7f93b0735ca0.bottom == UIView:0x7f93b05223f0.bottom>: file /Users/mozilla/GitRepo/firefox-ios/Carthage/Checkouts/SnapKit/Source/Constraint.swift, line 265
(lldb) 

This happens with both Earl Grey and KIF Test framework, which did not happen with Swift 2. It could be worth investigating, as the failure did not come from the test framework calls.
No longer depends on: 1337736
Correction: actually the crash happened when the username field element handle was accessed by the test framework call
Blocks: 1338346
No longer blocks: 1338346
Assignee: nobody → etoop
Status: NEW → ASSIGNED
Attached file Pull request
Attachment #8836015 - Flags: review?(sleroux)
Attachment #8836015 - Flags: review?(sleroux) → review+
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks: 1338607
No longer blocks: 1338607
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: