Closed Bug 1338339 Opened 7 years ago Closed 6 years ago

Intermittent dom/xhr/tests/browser_blobFromFile.js | The size matches - Got 28789, expected 31064

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: baku)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:logic])

Attachments

(1 file)

intermittent.patch
2.43 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Priority: -- → P5
on the 19th, this started failing at a very high failure rate for linux (mostly debug/asan, some opt) on both e10s and non-e10s.

:overholt, can you help find someone to look into this?
Flags: needinfo?(overholt)
Priority: P5 → --
Whiteboard: [stockwell needswork:DOM]
Oops, I meant to needinfo baku here.
Flags: needinfo?(overholt) → needinfo?(amarchesini)
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)

        Attachment #8889524 -
        Flags: review?(bugs)

    
    

    
  
The issue here is that pref.js is overwritten and it changes the size during the test. Better to use a different file for testing.

    
    

    
  
Comment on attachment 8889524 [details] [diff] [review]
intermittent.patch


>+  let fileData = "";
>+  for (var i = 0; i < 100; ++i) {
>+    fileData += "hello world!";
>+  }
Wouldn't let fileData = (new Array(100)).join("hello world!"); be a bit  simpler. But no need to change.



We don't need to remove the created file?

        Attachment #8889524 -
        Flags: review?(bugs) → review+

    
    

    
  
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/130073f0bc06
dom/xhr/tests/browser_blobFromFile.js must use a separate file for testing instead of prefs.js, r=smaug

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/130073f0bc06
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox56:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Whiteboard: [stockwell needswork:DOM] → [stockwell fixed:logic]

    
    

    
      
  
Component: DOM → DOM: Core & HTML

          You need to log in
          before you can comment on or make changes to this bug.