1338348 - The onboarding firstrun page should make the skip button inactive if someone begins to enter credentials

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Verdi [:verdi] Best to slack me]

Attachment: skip-setup.png

Pages https://www.mozilla.org/en-US/firefox/51.0.1/firstrun/?f=99 and https://www.mozilla.org/en-US/firefox/51.0.1/firstrun/?f=100 include a skip button that currently remains active when a user is going through the sign in or sign up process. Having the skip button active gives the user the impression that they can skip part of the process but clicking it will cancel the process. 

We should make the skip button inactive once someone begins to type their credentials into the form.

There is work on the FxA side needed to make this possible.

Comment 1

[Erica Wright [:ewright]]

PR is up and waiting for review https://github.com/mozilla/bedrock/pull/4664

Comment 2

[Shane Tomlinson [:stomlinson]]

The content server portion of this has landed and is now in production.

Comment 3

[Jon Petto [:jpetto]]

During code review, it came up that there appears to be a logic gap with the new postMessages. We listen for the "form_disabled" postMessage to re-enable the "skip" button when the user deletes info from the form. However, when a user clicks either "Sign in" or "Create account", the postMessage "form_disabled" is again sent. Because we can't tell why "form_disabled" is emitted, this results in the "skip" button being re-enabled while a login or account creation is processing.

This isn't a functional issue, but then again this bug isn't about functionality, it's about good UI.

I suppose we could add additional info to the "data" object sent along with the "form_disabled" postMessage, something like "nextAction" being either "re-enable" (for a user deleting info from the form) or "working" when the form is processing a login/signup.

Alternatively, maybe we don't send the "form_disabled" postMessage when a login/signup is in progress.

I don't think we can go live with the current functionality, as it's almost worse than just having "skip" enabled all the time.

The current branch is up on demo3 [1] if you'd like to test.

Thoughts?


[1] https://www-demo3.allizom.org/en-US/firefox/51.0/firstrun/?f=99

Comment 4

[Erica Wright [:ewright]]

During discussion we had agreed that at the least we want the skip button to disappear after a form submission, and second to that it would be a bonus if the button could visually fade when the form is ready to submit. So one option, in the interest of getting this out, would be to skip the second portion. 


(In reply to Jon Petto [:jpetto] from comment #3)
> During code review, it came up that there appears to be a logic gap with the
> new postMessages. We listen for the "form_disabled" postMessage to re-enable
> the "skip" button when the user deletes info from the form. However, when a
> user clicks either "Sign in" or "Create account", the postMessage
> "form_disabled" is again sent. Because we can't tell why "form_disabled" is
> emitted, this results in the "skip" button being re-enabled while a login or
> account creation is processing.
> 
> This isn't a functional issue, but then again this bug isn't about
> functionality, it's about good UI.
> 
> I suppose we could add additional info to the "data" object sent along with
> the "form_disabled" postMessage, something like "nextAction" being either
> "re-enable" (for a user deleting info from the form) or "working" when the
> form is processing a login/signup.
> 
> Alternatively, maybe we don't send the "form_disabled" postMessage when a
> login/signup is in progress.
> 
> I don't think we can go live with the current functionality, as it's almost
> worse than just having "skip" enabled all the time.
> 
> The current branch is up on demo3 [1] if you'd like to test.
> 
> Thoughts?
> 
> 
> [1] https://www-demo3.allizom.org/en-US/firefox/51.0/firstrun/?f=99

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/55bead0e3dd8be7de19d4db7851c232e09c780f0
[fix bug 1338348] - hide skip button on form engaged, show on disabled. Remove button on navigation.