On this page for instance, https://www.mozilla.org/fr/thunderbird/channel/ the download buttons are serving respectively: https://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-aurora/thunderbird-53.0a2.en-US.mac.dmg and https://download.mozilla.org/?product=thunderbird-52.0b1-SSL&os=osx&lang=en-US While the localized builds are correctly available through https://www.mozilla.org/en-US/thunderbird/beta/all/
Hmmm… right, I can’t reproduce either on a Windows 10 VM. However, in addition to Nightly, I tried with both Chrome and Safari on macOS, and I can still reproduce. Maybe only affecting macOS?
Actually, just realized this is also affecting https://www.mozilla.org/fr/firefox/channel/desktop/ so nothing to do with Thunderbird.
Component: Thunderbird → General
Summary: Thunderbird channel page serves en-US builds on localized pages → Firefox & Thunderbird channel page serves en-US builds on localized pages
Confirmed, this is definitely broken in Fx51 and Chrome on OSX.
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86
I can also reproduce with the main download page: https://www.mozilla.org/fr/firefox/new/?scene=2 So, we seem to be serving mac users English builds all over the board
Summary: Firefox & Thunderbird channel page serves en-US builds on localized pages → Firefox/Thunderbird channel & download pages serve en-US builds on localized pages for mac users
I don't like raising priority of a bug, but this is pretty awful.
Severity: normal → critical
Hmm, recent regression maybe? Will take a look tomorrow.
Assignee: nobody → kohei.yoshino
Status: NEW → ASSIGNED
I was thinking of bug 1330000, but that only changed labels for OS X, and I can't spot anything in the code that explains ignoring the locale.
Yeah, your guess seems right. My quick investigation: p-d still says "OS X": https://product-details.mozilla.org/1.0/firefox_primary_builds.json https://product-details.mozilla.org/1.0/thunderbird_primary_builds.json It doesn't match the new internal label "macOS", and in that case, the download button's locale fall backs to en-US: https://github.com/mozilla/bedrock/blob/master/bedrock/firefox/templatetags/helpers.py#L41-L43 https://github.com/mozilla/bedrock/blob/master/bedrock/thunderbird/templatetags/helpers.py#L45-L47
The Windows XP/Vista buttons have also been affected, but nobody seems noticed that?
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/21fa360538424243fb5a605e1ccd630e19291b0a Fix Bug 1338394 - Firefox/Thunderbird channel & download pages serve en-US builds on localized pages for mac users https://github.com/mozilla/bedrock/commit/e2527ab638e08f36dd8075d0b383a56d4609055a Merge pull request #4658 from kyoshino/bug-1338394-download-l10n Fix Bug 1338394 - Firefox/Thunderbird channel & download pages serve en-US builds on localized pages for mac users
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
The fix is now deployed on production. Théo: Can you verify that?
Thanks Kohei, looks good now :) Verified fixed on macOS 10.12.3 fr with Chrome, Safari, Firefox release and Nightly
Status: RESOLVED → VERIFIED
Also tested on Firefox fr with Windows XP
(In reply to Kohei Yoshino [:kohei] from comment #11) > The Windows XP/Vista buttons have also been affected, but nobody seems > noticed that? Thanks for the fix Kohei! Note this did not effect sha1 download links for Firefox thankfully, only Thunderbird locales, which is probably how it went unnoticed (Firefox was the focus for QA).
You need to log in before you can comment on or make changes to this bug.