Firefox/Thunderbird channel & download pages serve en-US builds on localized pages for mac users

VERIFIED FIXED

Status

www.mozilla.org
General
--
critical
VERIFIED FIXED
a year ago
a year ago

People

(Reporter: tchevalier, Assigned: kohei)

Tracking

(Blocks: 1 bug, {regression})

Production
x86
Mac OS X
regression

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I can't reproduce this. https://www.mozilla.org/fr/thunderbird/channel/ serves https://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/latest-comm-aurora-l10n/thunderbird-53.0a2.fr.win32.installer.exe
for me.

Is it possible some add-on or javascript blocking is affecting the page?
Hmmm… right, I can’t reproduce either on a Windows 10 VM.

However, in addition to Nightly, I tried with both Chrome and Safari on macOS, and I can still reproduce. Maybe only affecting macOS?
Actually, just realized this is also affecting https://www.mozilla.org/fr/firefox/channel/desktop/ so nothing to do with Thunderbird.
Component: Thunderbird → General
Summary: Thunderbird channel page serves en-US builds on localized pages → Firefox & Thunderbird channel page serves en-US builds on localized pages
Confirmed, this is definitely broken in Fx51 and Chrome on OSX.
OS: Unspecified → Mac OS X
Hardware: Unspecified → x86
I can also reproduce with the main download page: https://www.mozilla.org/fr/firefox/new/?scene=2

So, we seem to be serving mac users English builds all over the board
Summary: Firefox & Thunderbird channel page serves en-US builds on localized pages → Firefox/Thunderbird channel & download pages serve en-US builds on localized pages for mac users
I don't like raising priority of a bug, but this is pretty awful.
Severity: normal → critical
(Assignee)

Comment 7

a year ago
Hmm, recent regression maybe? Will take a look tomorrow.
Assignee: nobody → kohei.yoshino
Blocks: 813052
Status: NEW → ASSIGNED
I was thinking of bug 1330000, but that only changed labels for OS X, and I can't spot anything in the code that explains ignoring the locale.
(Assignee)

Comment 10

a year ago
Created attachment 8835915 [details] [review]
pull request
(Assignee)

Comment 11

a year ago
The Windows XP/Vista buttons have also been affected, but nobody seems noticed that?
Keywords: regression

Comment 12

a year ago
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/21fa360538424243fb5a605e1ccd630e19291b0a
Fix Bug 1338394 - Firefox/Thunderbird channel & download pages serve en-US builds on localized pages for mac users

https://github.com/mozilla/bedrock/commit/e2527ab638e08f36dd8075d0b383a56d4609055a
Merge pull request #4658 from kyoshino/bug-1338394-download-l10n

Fix Bug 1338394 - Firefox/Thunderbird channel & download pages serve en-US builds on localized pages for mac users

Updated

a year ago
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
(Assignee)

Comment 13

a year ago
The fix is now deployed on production. Théo: Can you verify that?
Flags: needinfo?(theo)
Thanks Kohei, looks good now :)

Verified fixed on macOS 10.12.3 fr with Chrome, Safari, Firefox release and Nightly
Status: RESOLVED → VERIFIED
Flags: needinfo?(theo)
Also tested on Firefox fr with Windows XP
(Assignee)

Comment 16

a year ago
\o/
(In reply to Kohei Yoshino [:kohei] from comment #11)
> The Windows XP/Vista buttons have also been affected, but nobody seems
> noticed that?

Thanks for the fix Kohei! Note this did not effect sha1 download links for Firefox thankfully, only Thunderbird locales, which is probably how it went unnoticed (Firefox was the focus for QA).
You need to log in before you can comment on or make changes to this bug.