1338426 - gfx/2d/2d.h should not include gfxPrefs.h

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Kelsey Gilbert [:jgilbert]]

It causes a large cascade of altered TUs when changes are made to this header.
It's easy enough to isolate its use to a single TU.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1338426 - gfx/2d/2D.h should not include gfxPrefs.h. -

Review commit: https://reviewboard.mozilla.org/r/111428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/111428/

Comment 2

[Bas Schouten (:bas.schouten)]

Comment on attachment 8835860 [details]
Bug 1338426 - gfx/2d/2D.h should not include gfxPrefs.h. -

https://reviewboard.mozilla.org/r/111428/#review113716

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dbf0a33cc36
gfx/2d/2D.h should not include gfxPrefs.h. - r=bas

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for build bustage:

https://hg.mozilla.org/integration/mozilla-inbound/rev/8a0b376c0afac43608015827a4c34b37eab3b718

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=1dbf0a33cc36641f13a084fbdd0b9a23005598e5
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=77336538&repo=mozilla-inbound

[task 2017-02-14T20:20:36.807973Z] 20:20:36     INFO -  /home/worker/workspace/build/src/sccache2/sccache /home/worker/workspace/build/src/gcc/bin/g++ -std=gnu++11 -o dtptngen.o -c  -I/home/worker/workspace/build/src/obj-firefox/dist/system_wrappers -include /home/worker/workspace/build/src/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DU_I18N_IMPLEMENTATION -DUCONFIG_NO_BREAK_ITERATION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DUCONFIG_NO_LEGACY_CONVERSION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_CHARSET_IS_UTF8 -I/home/worker/workspace/build/src/config/external/icu/i18n -I/home/worker/workspace/build/src/obj-firefox/config/external/icu/i18n -I/home/worker/workspace/build/src/intl/icu/source/common -I/home/worker/workspace/build/src/obj-firefox/dist/include  -I/home/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/home/worker/workspace/build/src/obj-firefox/dist/include/nss       -fPIC  -DMOZILLA_CLIENT -include /home/worker/workspace/build/src/obj-firefox/mozilla-config.h -MD -MP -MF .deps/dtptngen.o.pp  -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -D_GLIBCXX_USE_CXX11_ABI=0 -pipe  -g -freorder-blocks -Os -fno-omit-frame-pointer  -frtti  /home/worker/workspace/build/src/intl/icu/source/i18n/dtptngen.cpp
[task 2017-02-14T20:20:36.843602Z] 20:20:36     INFO -  In file included from /home/worker/workspace/build/src/gfx/2d/unittest/TestBugs.cpp:7:0,
[task 2017-02-14T20:20:36.843785Z] 20:20:36     INFO -                   from /home/worker/workspace/build/src/obj-firefox/gfx/tests/gtest/Unified_cpp_gfx_tests_gtest0.cpp:11:
[task 2017-02-14T20:20:36.843918Z] 20:20:36     INFO -  /home/worker/workspace/build/src/gfx/2d/2D.h:509:39: error: 'MallocSizeOf' has not been declared
[task 2017-02-14T20:20:36.844040Z] 20:20:36     INFO -     virtual void AddSizeOfExcludingThis(MallocSizeOf aMallocSizeOf,
[task 2017-02-14T20:20:36.844191Z] 20:20:36     INFO -                                         ^
[task 2017-02-14T20:20:36.844340Z] 20:20:36     INFO -  /home/worker/workspace/build/src/config/rules.mk:1016: recipe for target 'Unified_cpp_gfx_tests_gtest0.o' failed
[task 2017-02-14T20:20:36.844479Z] 20:20:36     INFO -  gmake[5]: *** [Unified_cpp_gfx_tests_gtest0.o] Error 1

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e29ec07ff48b
gfx/2d/2D.h should not include gfxPrefs.h. - r=bas

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/e29ec07ff48b