Conformance: Atomics operations should use ToIndex, not ToInteger, to convert and range check indices

RESOLVED FIXED in Firefox 54

Status

()

defect
P1
normal
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: lth, Assigned: lth)

Tracking

(Blocks 1 bug)

unspecified
mozilla54
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox54 fixed)

Details

Attachments

(1 attachment)

See https://github.com/tc39/ecma262/pull/811.  We should wait for that PR to land but this is almost certainly a done deal.

See also bug 1317383, bug 1317382.
Assignee: nobody → lhansen
I think this is all that's needed.  While the MIR nodes for the atomic operations use IntPolicy for this argument and in principle need to change, those nodes are only created if the input is already Int32, so we should be OK on that.
Attachment #8837997 - Flags: review?(shu)
Comment on attachment 8837997 [details] [diff] [review]
bug1338449-use-toindex.patch

Review of attachment 8837997 [details] [diff] [review]:
-----------------------------------------------------------------

Could you write the test262 tests as well and upstream PR them?
Attachment #8837997 - Flags: review?(shu) → review+
(In reply to Shu-yu Guo [:shu] from comment #2)
> 
> Could you write the test262 tests as well and upstream PR them?

I have done so.
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fc0af6d26ce88ebb456d55e80a7f24f66fc6d87
Bug 1338449 - use ToIndex to convert TA indices for atomic operations. r=shu
https://hg.mozilla.org/mozilla-central/rev/5fc0af6d26ce
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla54
You need to log in before you can comment on or make changes to this bug.