1338451 - editor should commit composition when mousedown event is received first

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Currently, EditorEventListener::MouseDown() commits composition but it's called *after* HTMLEditorEventListener::MouseDown() does something. It may cause some trouble, so, HTMLEditorEventListener::MouseDown() should commit composition first, then, it should do something.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dd2a91f548f

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1338451 Editor should commit composition first at handling mousedown event

Editor may need to create some new transaction during handling a mousedown event.  Therefore, editor needs to finish pending composition transaction.  So, mousedown event handler should commit composition first.

Review commit: https://reviewboard.mozilla.org/r/112536/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/112536/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8837398 [details]
Bug 1338451 Editor should commit composition first at handling mousedown event

https://reviewboard.mozilla.org/r/112536/#review114008

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f246ac3d663
Editor should commit composition first at handling mousedown event r=m_kato

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5f246ac3d663