Closed
Bug 1338517
Opened 7 years ago
Closed 7 years ago
[Static Analysis][Dereference before null check] In function mergeStacksIntoProfile
Categories
(Core :: Gecko Profiler, defect)
Core
Gecko Profiler
Tracking
()
RESOLVED
INVALID
Tracking | Status | |
---|---|---|
firefox54 | --- | affected |
People
(Reporter: andi, Assigned: andi)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: CID 1400179)
Attachments
(1 file)
The Static Analysis tool Coverity detected that variable |aSample| might be null thus a null pointer dereference may happen. presumably null pointer dereference: >> if (aSample->isSamplingCurrentThread) { >> startBufferGen = UINT32_MAX; >> } else { >> startBufferGen = aInfo.bufferGeneration(); >> } null check: >> if (aSample && autoWalkJSStack.walkAllowed) { >> JS::ProfilingFrameIterator::RegisterState registerState; But if we check the calling path for mergeStacksIntoProfile we can see that variable |sample| thats passed from: >> profile->BeginUnwind(); >> Tick(&sample); >> profile->EndUnwind(); So in order to silence the checker i suggest removing the null check.
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8836008 [details] Bug Bug 1338517 - fix false positive for static analysis in mergeStacksIntoProfile. https://reviewboard.mozilla.org/r/111532/#review112896 Thanks
Attachment #8836008 -
Flags: review?(mstange) → review+
Comment 3•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again. hg error in cmd: hg rebase -s f4575cac3c40 -d b24055689799: rebasing 388345:f4575cac3c40 "Bug Bug 1338517 - fix false positive for static analysis in mergeStacksIntoProfile. r=mstange" (tip) other [source] changed tools/profiler/core/Sampler.cpp which local [dest] deleted use (c)hanged version, leave (d)eleted, or leave (u)nresolved? u unresolved conflicts (see hg resolve, then hg rebase --continue)
Assignee | ||
Updated•7 years ago
|
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•