Closed
Bug 1338539
Opened 7 years ago
Closed 7 years ago
files with application/manifest+json Mime type should be rendered as json
Categories
(DevTools :: JSON Viewer, defect)
DevTools
JSON Viewer
Tracking
(firefox54 fixed)
VERIFIED
FIXED
Firefox 54
Tracking | Status | |
---|---|---|
firefox54 | --- | fixed |
People
(Reporter: pascalc, Assigned: pascalc)
References
Details
Attachments
(1 file, 3 obsolete files)
Nightly 54, Linux 1/ go to https://pascalc.net/bug1338539/manifest.json ER: The manifest.json file should be rendered as Json in the browser AR: The file is proposed for download instead, this is because the Mime type is application/manifest+json (see https://developer.mozilla.org/en-US/docs/Web/Manifest) This is a follow up to bug 1336394 reported by Alice
Assignee | ||
Comment 1•7 years ago
|
||
Taking this bug as I have a simple patch that fixes it, attaching my WIP to the bug, need to add tests.
Assignee: nobody → pascalc
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8836072 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8837435 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Component: Developer Tools → Developer Tools: JSON Viewer
If this is ready for review, please ask :Honza for review!
Assignee | ||
Comment 5•7 years ago
|
||
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4) > If this is ready for review, please ask :Honza for review! Thanks, I think it is ready for review but I have only ran tests locally, not on a try server, I need to reread the documentation about that since I only did it once in the past and it was some time ago :)
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8837451 -
Attachment is obsolete: true
Assignee | ||
Comment 8•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=277e6762cc67
Comment 9•7 years ago
|
||
mozreview-review |
Comment on attachment 8839903 [details] Bug 1338539: files with application/manifest+json Mime type should be rendered as json https://reviewboard.mozilla.org/r/114456/#review117832 Sorry for the delay. The pach looks good to me, R+ assuming try is green. Thanks for working on this! Honza
Attachment #8839903 -
Flags: review?(odvarko) → review+
Comment 10•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47ae8eb50ef4 files with application/manifest+json Mime type should be rendered as json r=Honza
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/47ae8eb50ef4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 54
Assignee | ||
Comment 12•7 years ago
|
||
Verified on today's nightly, thanks Jan and Tomcat!
Status: RESOLVED → VERIFIED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•